starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-09-01 16:37:19 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #658] Implementation of delete (SPICE-0008) #660

New Issue
Open
opened 2025-12-30 01:26:00 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:26:00 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/658
Author: @holzensp
Created: 9/23/2024
Status: 🔄 Open

Base: main ← Head: delete

📝 Commits (2)

  • 2f0e1e0 Implement delete (SPICE-0008)
  • 30240e4 Define separate snippet tests for error cases and remove DeletionTest

📊 Changes

21 files changed (+462 additions, -48 deletions)

View changed files

📝 docs/modules/language-reference/pages/index.adoc (+40 -0)
📝 pkl-core/src/main/antlr/PklParser.g4 (+8 -9)
📝 pkl-core/src/main/java/org/pkl/core/ast/VmModifier.java (+9 -3)
📝 pkl-core/src/main/java/org/pkl/core/ast/builder/AstBuilder.java (+28 -5)
📝 pkl-core/src/main/java/org/pkl/core/ast/member/Member.java (+6 -2)
📝 pkl-core/src/main/java/org/pkl/core/runtime/TestRunner.java (+3 -2)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmDynamic.java (+1 -1)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmFunction.java (+1 -2)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmListing.java (+5 -0)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmMapping.java (+5 -0)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmObject.java (+169 -18)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmObjectLike.java (+6 -2)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmTyped.java (+5 -0)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmUtils.java (+18 -3)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmValue.java (+1 -1)
➕ pkl-core/src/test/files/LanguageSnippetTests/input/basic/delete.pkl (+97 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/input/errors/deleteInExpressionPosition.pkl (+8 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/input/errors/deleteRemovesKeyFromSuggestion.pkl (+8 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/output/basic/delete.pcf (+23 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/output/errors/deleteInExpressionPosition.err (+6 -0)

...and 1 more files

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/658 **Author:** [@holzensp](https://github.com/holzensp) **Created:** 9/23/2024 **Status:** 🔄 Open **Base:** `main` ← **Head:** `delete` --- ### 📝 Commits (2) - [`2f0e1e0`](https://github.com/apple/pkl/commit/2f0e1e071868f33547f61d457a6403c7a1a87df2) Implement `delete` (SPICE-0008) - [`30240e4`](https://github.com/apple/pkl/commit/30240e43c1fcd4a9c6886e7469637014d155969f) Define separate snippet tests for error cases and remove DeletionTest ### 📊 Changes **21 files changed** (+462 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `docs/modules/language-reference/pages/index.adoc` (+40 -0) 📝 `pkl-core/src/main/antlr/PklParser.g4` (+8 -9) 📝 `pkl-core/src/main/java/org/pkl/core/ast/VmModifier.java` (+9 -3) 📝 `pkl-core/src/main/java/org/pkl/core/ast/builder/AstBuilder.java` (+28 -5) 📝 `pkl-core/src/main/java/org/pkl/core/ast/member/Member.java` (+6 -2) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/TestRunner.java` (+3 -2) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmDynamic.java` (+1 -1) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmFunction.java` (+1 -2) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmListing.java` (+5 -0) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmMapping.java` (+5 -0) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmObject.java` (+169 -18) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmObjectLike.java` (+6 -2) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmTyped.java` (+5 -0) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmUtils.java` (+18 -3) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmValue.java` (+1 -1) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input/basic/delete.pkl` (+97 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input/errors/deleteInExpressionPosition.pkl` (+8 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input/errors/deleteRemovesKeyFromSuggestion.pkl` (+8 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/output/basic/delete.pcf` (+23 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/output/errors/deleteInExpressionPosition.err` (+6 -0) _...and 1 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:26:00 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#660