[PR #506] [MERGED] Add support for HTTP proxying #590

New Issue

adam · 2025-12-30T01:25:31+01:00

adam commented

2025-12-30 01:25:31 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/506
Author: @holzensp
Created: 5/27/2024
Status: ✅ Merged
Merged: 6/12/2024
Merged by: @bioball

Base: main ← Head: http-proxy

📝 Commits (10+)

a0576fa Add proxy to settings and reshuffle stdlib settings
b0942e9 Add proxy settings to internal HTTP client
54c629a Add WireMock dependency
1a7b8b2 Add proxy tests
4a2fa08 Force native-image to use system proxy settings in CLI
ccf7217 Apply suggestions from code review
682b8fa Rollback const modifiers for editor settings
0aed242 Restore and deprecate EvaluatorSettings
487dd56 Rollback validation of --no-proxy requiring --proxy
a8c8fc0 Restore equality and hashability for PklEvaluatorSettings

📊 Changes

61 files changed (+1581 additions, -412 deletions)

View changed files

📝 bench/gradle.lockfile (+2 -2)
📝 docs/gradle.lockfile (+2 -2)
📝 docs/modules/bindings-specification/pages/message-passing-api.adoc (+51 -0)
📝 docs/modules/pkl-cli/pages/index.adoc (+15 -0)
📝 docs/modules/pkl-cli/partials/cli-common-options.adoc (+18 -0)
📝 docs/modules/pkl-gradle/partials/gradle-common-properties.adoc (+18 -0)
📝 gradle/libs.versions.toml (+2 -0)
📝 pkl-certs/gradle.lockfile (+2 -2)
📝 pkl-cli/gradle.lockfile (+61 -10)
📝 pkl-cli/pkl-cli.gradle.kts (+1 -0)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliServer.kt (+1 -1)
📝 pkl-cli/src/test/kotlin/org/pkl/cli/CliEvaluatorTest.kt (+198 -0)
📝 pkl-codegen-java/gradle.lockfile (+2 -2)
📝 pkl-codegen-kotlin/gradle.lockfile (+2 -2)
📝 pkl-commons-cli/gradle.lockfile (+2 -2)
📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliBaseOptions.kt (+6 -21)
📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliCommand.kt (+46 -13)
📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliMain.kt (+3 -0)
📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/commands/BaseOptions.kt (+29 -1)
📝 pkl-commons-test/gradle.lockfile (+2 -2)

...and 41 more files

📄 Description

Following design of SPICE-0004.

Compared to #472; Re-organizes Pkl config, cleans up commits, and adds ability to use proxy settings from the system (macOS, Windows, GNOME).

Closes #472

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/506 **Author:** [@holzensp](https://github.com/holzensp) **Created:** 5/27/2024 **Status:** ✅ Merged **Merged:** 6/12/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `http-proxy` --- ### 📝 Commits (10+) - [`a0576fa`](https://github.com/apple/pkl/commit/a0576faea6611efee7539cb2f1f185029c5717d4) Add proxy to settings and reshuffle stdlib settings - [`b0942e9`](https://github.com/apple/pkl/commit/b0942e95397f66d8f924eb0336d91b093052cd9c) Add proxy settings to internal HTTP client - [`54c629a`](https://github.com/apple/pkl/commit/54c629ad8d6b5a4422bd459c4a0f1b21ddfe7904) Add WireMock dependency - [`1a7b8b2`](https://github.com/apple/pkl/commit/1a7b8b2097123b9a77a7f409861c28f441d7281e) Add proxy tests - [`4a2fa08`](https://github.com/apple/pkl/commit/4a2fa085e5b93ed738ff56169c1d6fe2a78f2bfc) Force native-image to use system proxy settings in CLI - [`ccf7217`](https://github.com/apple/pkl/commit/ccf7217a71111785940ea0d0243b8b029a64772b) Apply suggestions from code review - [`682b8fa`](https://github.com/apple/pkl/commit/682b8fa73e0f5aaf3eb8d424da78f8451724624c) Rollback `const` modifiers for editor settings - [`0aed242`](https://github.com/apple/pkl/commit/0aed24291544de8ff8f387595f0bd3323e4591ce) Restore and deprecate EvaluatorSettings - [`487dd56`](https://github.com/apple/pkl/commit/487dd5635bb145f70a5058913f2eb73356c16b18) Rollback validation of `--no-proxy` requiring `--proxy` - [`a8c8fc0`](https://github.com/apple/pkl/commit/a8c8fc092d4f9ccfce61b50ff45bb70698437066) Restore equality and hashability for `PklEvaluatorSettings` ### 📊 Changes **61 files changed** (+1581 additions, -412 deletions) <details> <summary>View changed files</summary> 📝 `bench/gradle.lockfile` (+2 -2) 📝 `docs/gradle.lockfile` (+2 -2) 📝 `docs/modules/bindings-specification/pages/message-passing-api.adoc` (+51 -0) 📝 `docs/modules/pkl-cli/pages/index.adoc` (+15 -0) 📝 `docs/modules/pkl-cli/partials/cli-common-options.adoc` (+18 -0) 📝 `docs/modules/pkl-gradle/partials/gradle-common-properties.adoc` (+18 -0) 📝 `gradle/libs.versions.toml` (+2 -0) 📝 `pkl-certs/gradle.lockfile` (+2 -2) 📝 `pkl-cli/gradle.lockfile` (+61 -10) 📝 `pkl-cli/pkl-cli.gradle.kts` (+1 -0) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliServer.kt` (+1 -1) 📝 `pkl-cli/src/test/kotlin/org/pkl/cli/CliEvaluatorTest.kt` (+198 -0) 📝 `pkl-codegen-java/gradle.lockfile` (+2 -2) 📝 `pkl-codegen-kotlin/gradle.lockfile` (+2 -2) 📝 `pkl-commons-cli/gradle.lockfile` (+2 -2) 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliBaseOptions.kt` (+6 -21) 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliCommand.kt` (+46 -13) 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliMain.kt` (+3 -0) 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/commands/BaseOptions.kt` (+29 -1) 📝 `pkl-commons-test/gradle.lockfile` (+2 -2) _...and 41 more files_ </details> ### 📄 Description Following design of [SPICE-0004](https://github.com/apple/pkl-evolution/pull/5). Compared to #472; Re-organizes Pkl config, cleans up commits, and adds ability to use proxy settings from the system (macOS, Windows, GNOME). Closes #472 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:25:31 +01:00

adam closed this issue

2025-12-30 01:25:31 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#590