starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 22:30:54 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #241] [MERGED] Windows installation notes #472

New Issue
Closed
opened 2025-12-30 01:24:42 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:24:42 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/241
Author: @mitchcapper
Created: 2/23/2024
Status: ✅ Merged
Merged: 4/24/2024
Merged by: @holzensp

Base: main ← Head: windows_cli_install_notes

📝 Commits (1)

  • f58ebf0 Windows installation notes

📊 Changes

1 file changed (+24 additions, -1 deletions)

View changed files

📝 docs/modules/pkl-cli/pages/index.adoc (+24 -1)

📄 Description

Per #237 notes about Windows platform support for the install docs. Assuming this is what was desired will add additional docs to --allowed-modules and update https://github.com/apple/pkl-jvm-examples/pull/9 . https://github.com/apple/pkl-jvm-examples/pull/9 is mostly not related to Windows, just likely Windows users may run into issues around its usage.

I am not sure what items other than allowed-modules may specifically have path related issues or if there is a better place to discuss Windows paths in more detail.

I have not found a way to sparse-checkout (cone or no-cone) or ignore the two invalid window path areas:

  • pkl-doc/src/test/files/DocGeneratorTest/output/*
  • pkl-core/src/test/files/LanguageSnippetTests/input-helper/globtest/*

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/241 **Author:** [@mitchcapper](https://github.com/mitchcapper) **Created:** 2/23/2024 **Status:** ✅ Merged **Merged:** 4/24/2024 **Merged by:** [@holzensp](https://github.com/holzensp) **Base:** `main` ← **Head:** `windows_cli_install_notes` --- ### 📝 Commits (1) - [`f58ebf0`](https://github.com/apple/pkl/commit/f58ebf0bc76bc7c9da9a8c221f1691444a8c5200) Windows installation notes ### 📊 Changes **1 file changed** (+24 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `docs/modules/pkl-cli/pages/index.adoc` (+24 -1) </details> ### 📄 Description Per #237 notes about Windows platform support for the install docs. Assuming this is what was desired will add additional docs to --allowed-modules and update https://github.com/apple/pkl-jvm-examples/pull/9 . https://github.com/apple/pkl-jvm-examples/pull/9 is mostly not related to Windows, just likely Windows users may run into issues around its usage. I am not sure what items other than allowed-modules may specifically have path related issues or if there is a better place to discuss Windows paths in more detail. I have not found a way to sparse-checkout (cone or no-cone) or ignore the two invalid window path areas: - pkl-doc/src/test/files/DocGeneratorTest/output/* - pkl-core/src/test/files/LanguageSnippetTests/input-helper/globtest/* --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:24:42 +01:00
adam closed this issue 2025-12-30 01:24:42 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#472
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?