starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-13 15:13:38 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #454] [MERGED] JDK version bump cleaups #559

New Issue
Closed
opened 2025-12-30 01:25:20 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:25:20 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/454
Author: @bioball
Created: 4/25/2024
Status: ✅ Merged
Merged: 4/26/2024
Merged by: @bioball

Base: main ← Head: ci-jdk-fix

📝 Commits (6)

  • c43a452 Bump JDK when running simple gradle CI jobs
  • dabb594 Bump minimum Gradle version to 8.1
  • def6c85 Fix docs, and fix minimum version checker
  • eacb591 Remove bench/gradle compat from prb
  • d1cac72 Update MIN_GRADLE_VERSION
  • bbd26b6 Add previously deleted line

📊 Changes

17 files changed (+21 additions, -25 deletions)

View changed files

📝 .circleci/config.yml (+2 -2)
📝 .circleci/jobs/SimpleGradleJob.pkl (+1 -1)
📝 DEVELOPMENT.adoc (+2 -2)
📝 docs/modules/java-binding/pages/codegen.adoc (+1 -1)
📝 docs/modules/java-binding/pages/pkl-config-java.adoc (+1 -1)
📝 docs/modules/kotlin-binding/pages/codegen.adoc (+1 -1)
📝 docs/modules/kotlin-binding/pages/pkl-config-kotlin.adoc (+1 -1)
📝 docs/modules/pkl-cli/pages/index.adoc (+3 -3)
📝 docs/modules/pkl-core/pages/index.adoc (+1 -1)
📝 docs/modules/pkl-doc/pages/index.adoc (+1 -1)
📝 docs/modules/pkl-gradle/pages/index.adoc (+1 -1)
📝 pkl-cli/pkl-cli.gradle.kts (+1 -1)
📝 pkl-cli/src/test/kotlin/org/pkl/cli/CliEvaluatorTest.kt (+1 -2)
📝 pkl-core/src/main/java/org/pkl/core/http/JdkHttpClient.java (+0 -3)
📝 pkl-gradle/pkl-gradle.gradle.kts (+1 -1)
📝 pkl-gradle/src/main/java/org/pkl/gradle/PklPlugin.java (+1 -1)
📝 settings.gradle.kts (+2 -2)

📄 Description

  • Fix CI job for bench and gradle-compatibility
  • Fix documentation issues around Java compatibility (Java 11 -> Java 17)
  • Bump minimum Gradle version to 8.1

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/454 **Author:** [@bioball](https://github.com/bioball) **Created:** 4/25/2024 **Status:** ✅ Merged **Merged:** 4/26/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `ci-jdk-fix` --- ### 📝 Commits (6) - [`c43a452`](https://github.com/apple/pkl/commit/c43a45208dddd7a306979ca84d3423578cbf328e) Bump JDK when running simple gradle CI jobs - [`dabb594`](https://github.com/apple/pkl/commit/dabb59423ce6257651ba082ccf93e66c5d306175) Bump minimum Gradle version to 8.1 - [`def6c85`](https://github.com/apple/pkl/commit/def6c85d3b3f8398cff9b5da5135d1ba0d0daf68) Fix docs, and fix minimum version checker - [`eacb591`](https://github.com/apple/pkl/commit/eacb5915a966a8de5d4a7ab6b09e27e3b04ceddf) Remove bench/gradle compat from prb - [`d1cac72`](https://github.com/apple/pkl/commit/d1cac728659227548aac5bb1fbfebfa578b7bb7e) Update MIN_GRADLE_VERSION - [`bbd26b6`](https://github.com/apple/pkl/commit/bbd26b6e5fce5cc4f45829c8cb694625784b0704) Add previously deleted line ### 📊 Changes **17 files changed** (+21 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `.circleci/config.yml` (+2 -2) 📝 `.circleci/jobs/SimpleGradleJob.pkl` (+1 -1) 📝 `DEVELOPMENT.adoc` (+2 -2) 📝 `docs/modules/java-binding/pages/codegen.adoc` (+1 -1) 📝 `docs/modules/java-binding/pages/pkl-config-java.adoc` (+1 -1) 📝 `docs/modules/kotlin-binding/pages/codegen.adoc` (+1 -1) 📝 `docs/modules/kotlin-binding/pages/pkl-config-kotlin.adoc` (+1 -1) 📝 `docs/modules/pkl-cli/pages/index.adoc` (+3 -3) 📝 `docs/modules/pkl-core/pages/index.adoc` (+1 -1) 📝 `docs/modules/pkl-doc/pages/index.adoc` (+1 -1) 📝 `docs/modules/pkl-gradle/pages/index.adoc` (+1 -1) 📝 `pkl-cli/pkl-cli.gradle.kts` (+1 -1) 📝 `pkl-cli/src/test/kotlin/org/pkl/cli/CliEvaluatorTest.kt` (+1 -2) 📝 `pkl-core/src/main/java/org/pkl/core/http/JdkHttpClient.java` (+0 -3) 📝 `pkl-gradle/pkl-gradle.gradle.kts` (+1 -1) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/PklPlugin.java` (+1 -1) 📝 `settings.gradle.kts` (+2 -2) </details> ### 📄 Description * Fix CI job for bench and gradle-compatibility * Fix documentation issues around Java compatibility (Java 11 -> Java 17) * Bump minimum Gradle version to 8.1 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:20 +01:00
adam closed this issue 2025-12-30 01:25:20 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#559
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?