starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-09-02 00:47:18 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #216] [MERGED] Skip POM validation for unpublished projects #454

New Issue
Closed
opened 2025-12-30 01:24:34 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:24:34 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/216
Author: @sgammon
Created: 2/20/2024
Status: ✅ Merged
Merged: 2/21/2024
Merged by: @holzensp

Base: main ← Head: fix/gradle-tasks-cmd

📝 Commits (1)

  • 663f0fa Skip POM validation for unpublished projects

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 buildSrc/src/main/kotlin/pklPublishLibrary.gradle.kts (+3 -0)

📄 Description

Summary

This small change fixes a bug introduced by the validatePom task within the pklPublishLibrary plugin. When running project-wide tasks like ./gradle tasks, projects which don't provide a POM fail the build, because the generatePomFileForLibraryPublication cannot be found, but it is expected to be present.

With this change applied, validatePom only runs if the task generatePomFileForLibraryPublication is present in a given project.

Fixes and closes apple/pkl#215

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/216 **Author:** [@sgammon](https://github.com/sgammon) **Created:** 2/20/2024 **Status:** ✅ Merged **Merged:** 2/21/2024 **Merged by:** [@holzensp](https://github.com/holzensp) **Base:** `main` ← **Head:** `fix/gradle-tasks-cmd` --- ### 📝 Commits (1) - [`663f0fa`](https://github.com/apple/pkl/commit/663f0faab3b11351613ec9bf436d0ce8e48d9321) Skip POM validation for unpublished projects ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `buildSrc/src/main/kotlin/pklPublishLibrary.gradle.kts` (+3 -0) </details> ### 📄 Description ## Summary This small change fixes a bug introduced by the `validatePom` task within the `pklPublishLibrary` plugin. When running project-wide tasks like `./gradle tasks`, projects which don't provide a POM fail the build, because the `generatePomFileForLibraryPublication` cannot be found, but it is expected to be present. With this change applied, `validatePom` only runs if the task `generatePomFileForLibraryPublication` is present in a given project. Fixes and closes apple/pkl#215 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:24:34 +01:00
adam closed this issue 2025-12-30 01:24:34 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#454