starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 22:30:54 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

Fix empty parenthesized type unexpected error (#1323)

Browse Source
This commit is contained in:
Spencer Phillip Young
2025-11-18 06:35:44 -08:00
committed by GitHub
parent bc5d675b6e
commit ba281e8475
4 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
pkl-core/src/test/files/LanguageSnippetTests/input/errors/emptyParenthesizedTypeAnnotation.pkl vendored Normal file
View File

@@ -0,0 +1 @@
foo: Int|()|String = "foo"

6
pkl-core/src/test/files/LanguageSnippetTests/output/errors/emptyParenthesizedTypeAnnotation.err vendored Normal file
View File

@@ -0,0 +1,6 @@
–– Pkl Error ––
Unexpected token `)`. Expected a type.
x | foo: Int|()|String = "foo"
^
at emptyParenthesizedTypeAnnotation (file:///$snippetsDir/input/errors/emptyParenthesizedTypeAnnotation.pkl)

3
pkl-parser/src/main/java/org/pkl/parser/Parser.java
View File

@@ -1393,6 +1393,9 @@ public class Parser {
children.add(ret);
typ = new Type.FunctionType(children, tk.span.endWith(ret.span()));
} else {
if (children.isEmpty()) {
throw new ParserError(ErrorMessages.create("unexpectedTokenForType", ")"), end);
}
typ = new ParenthesizedType((Type) children.get(0), tk.span.endWith(end));
}
}

1
pkl-parser/src/test/kotlin/org/pkl/parser/ParserComparisonTest.kt
View File

@@ -105,6 +105,7 @@ class ParserComparisonTest {
"errors/moduleWithHighMinPklVersionAndParseErrors.pkl",
"errors/underscore.pkl",
"errors/shebang.pkl",
"errors/emptyParenthesizedTypeAnnotation.pkl",
"notAUnionDefault.pkl",
"multipleDefaults.pkl",
"modules/invalidModule1.pkl",