starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-04-25 09:48:41 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

Fix unnecessary temp path resolution in PackageResolvers (#219)

Browse Source 
The only call site already resolved the path against tmpDir.
This commit is contained in:
translatenix
2024-02-20 20:47:28 -08:00
committed by GitHub
parent ffc629f28f
commit 91367ed065
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pkl-core/src/main/java/org/pkl/core/packages/PackageResolvers.java
View File

@@ -446,13 +446,12 @@ class PackageResolvers {
return path.substring(lastSep + 1); return path.substring(lastSep + 1);
} }
private byte[] downloadUriToPathAndComputeChecksum(URI downloadUri, Path relativePath) private byte[] downloadUriToPathAndComputeChecksum(URI downloadUri, Path path)
throws IOException, SecurityManagerException { throws IOException, SecurityManagerException {
var tmpPath = tmpDir.resolve(relativePath); Files.createDirectories(path.getParent());
Files.createDirectories(tmpPath.getParent());
var inputStream = openExternalUri(downloadUri); var inputStream = openExternalUri(downloadUri);
try (var digestInputStream = newDigestInputStream(inputStream)) { try (var digestInputStream = newDigestInputStream(inputStream)) {
Files.copy(digestInputStream, tmpPath); Files.copy(digestInputStream, path);
return digestInputStream.getMessageDigest().digest(); return digestInputStream.getMessageDigest().digest();
} }
} }