From 91367ed0651683c578648d725547a72178de7004 Mon Sep 17 00:00:00 2001 From: translatenix <119817707+translatenix@users.noreply.github.com> Date: Tue, 20 Feb 2024 20:47:28 -0800 Subject: [PATCH] Fix unnecessary temp path resolution in PackageResolvers (#219) The only call site already resolved the path against tmpDir. --- .../main/java/org/pkl/core/packages/PackageResolvers.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/pkl-core/src/main/java/org/pkl/core/packages/PackageResolvers.java b/pkl-core/src/main/java/org/pkl/core/packages/PackageResolvers.java index 31b783fb..ea58a2d6 100644 --- a/pkl-core/src/main/java/org/pkl/core/packages/PackageResolvers.java +++ b/pkl-core/src/main/java/org/pkl/core/packages/PackageResolvers.java @@ -446,13 +446,12 @@ class PackageResolvers { return path.substring(lastSep + 1); } - private byte[] downloadUriToPathAndComputeChecksum(URI downloadUri, Path relativePath) + private byte[] downloadUriToPathAndComputeChecksum(URI downloadUri, Path path) throws IOException, SecurityManagerException { - var tmpPath = tmpDir.resolve(relativePath); - Files.createDirectories(tmpPath.getParent()); + Files.createDirectories(path.getParent()); var inputStream = openExternalUri(downloadUri); try (var digestInputStream = newDigestInputStream(inputStream)) { - Files.copy(digestInputStream, tmpPath); + Files.copy(digestInputStream, path); return digestInputStream.getMessageDigest().digest(); } }