starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-03-21 00:29:07 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

Turn EvalTask into a tracked Gradle task

Browse Source 
Rationale: "Output file names are known only after execution"
isn't a legitimate reason to make this task untracked
because the output directory is known in this case.
This is no different from (say) the `JavaCompile` task,
where only the class file output directory is known upfront.
Forum discussion didn't reveal another reason why this task
should be untracked.
This commit is contained in:
translatenix
2024-04-03 14:06:16 -07:00
committed by Philip K.F. Hölzenspies
parent 2392a3c22f
commit 3c6df1fe34
1 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
pkl-gradle/src/main/java/org/pkl/gradle/task/EvalTask.java
View File

@@ -19,26 +19,32 @@ import java.io.File;
import org.gradle.api.file.DirectoryProperty;
import org.gradle.api.file.RegularFileProperty;
import org.gradle.api.provider.Property;
import org.gradle.api.tasks.Internal;
import org.gradle.api.tasks.UntrackedTask;
import org.gradle.api.tasks.Input;
import org.gradle.api.tasks.Optional;
import org.gradle.api.tasks.OutputDirectory;
import org.gradle.api.tasks.OutputFile;
import org.pkl.cli.CliEvaluator;
import org.pkl.cli.CliEvaluatorOptions;
@UntrackedTask(because = "Output file names are known only after execution")
public abstract class EvalTask extends ModulesTask {
@Internal
@OutputFile
@Optional
public abstract RegularFileProperty getOutputFile();
@Internal
@Input
@Optional
public abstract Property<String> getOutputFormat();
@Internal
@Input
@Optional
public abstract Property<String> getModuleOutputSeparator();
@Internal
@OutputDirectory
@Optional
public abstract DirectoryProperty getMultipleFileOutputDir();
@Internal
@Input
@Optional
public abstract Property<String> getExpression();
@Override