Example custom script fails #9199

Closed
opened 2025-12-29 20:46:53 +01:00 by adam · 3 comments
Owner

Originally created by @aharrisson on GitHub (Feb 6, 2024).

Originally assigned to: @jeffgdotorg on GitHub.

Change Type

Correction

Area

Customization

Proposed Changes

The example custom script fails since it creates Device objects with the old "role" field, rather than "device_role".

Originally created by @aharrisson on GitHub (Feb 6, 2024). Originally assigned to: @jeffgdotorg on GitHub. ### Change Type Correction ### Area Customization ### Proposed Changes The example custom script fails since it creates Device objects with the old "role" field, rather than "device_role".
adam added the status: acceptedtype: documentation labels 2025-12-29 20:46:53 +01:00
adam closed this issue 2025-12-29 20:46:53 +01:00
Author
Owner

@jeffgdotorg commented on GitHub (Feb 9, 2024):

Good catch. Thanks for the issue and PR.

For future reference, our workflows require an accepted issue before a PR will be considered valid. For a one-line docs fix on a first issue, I'm going to let that go 😉

@jeffgdotorg commented on GitHub (Feb 9, 2024): Good catch. Thanks for the issue and PR. For future reference, our workflows require an accepted issue before a PR will be considered valid. For a one-line docs fix on a first issue, I'm going to let that go 😉
Author
Owner

@aharrisson commented on GitHub (Feb 9, 2024):

Thank for the merge, @jeffgdotorg. 👍

Sorry. I did actually read the contribution rules, but it seemed like a lot of overhead for such a minor change. I will make sure to follow the correct process in the event of any future contributions.

@aharrisson commented on GitHub (Feb 9, 2024): Thank for the merge, @jeffgdotorg. 👍 Sorry. I did actually read the contribution rules, but it seemed like a lot of overhead for such a minor change. I will make sure to follow the correct process in the event of any future contributions.
Author
Owner

@jeffgdotorg commented on GitHub (Feb 9, 2024):

Glad to do it, and glad to have you as a contributor!

Process wise there's a little bit of play in the gears for fixes as straightforward as this one. It matters more for changes with a broader scope.

@jeffgdotorg commented on GitHub (Feb 9, 2024): Glad to do it, and glad to have you as a contributor! Process wise there's a little bit of play in the gears for fixes as straightforward as this one. It matters more for changes with a broader scope.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#9199