starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #9199] [MERGED] Fixes #8941: Fix apiSelect scrolling while zoomed in chrome #13441

New Issue
Closed
opened 2025-12-29 22:27:26 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:27:26 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/9199
Author: @kkthxbye-code
Created: 4/22/2022
Status: ✅ Merged
Merged: 4/25/2022
Merged by: @jeremystretch

Base: develop ← Head: fix-8941

📝 Commits (1)

  • a91c46b UI: Fix apiSelect scrolling while zoomed in chrome

📊 Changes

3 files changed (+4 additions, -3 deletions)

View changed files

📝 netbox/project-static/dist/netbox.js (+1 -1)
📝 netbox/project-static/dist/netbox.js.map (+1 -1)
📝 netbox/project-static/src/select/api/apiSelect.ts (+2 -1)

📄 Description

Fixes: #8941

Just Math.floor() scrollTop so that the strict comparison has a chance to match when chrome returns fractions when zoomed at 110% and 67%.

Tested a bunch of different zoom levels, seems to work as intended.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/9199 **Author:** [@kkthxbye-code](https://github.com/kkthxbye-code) **Created:** 4/22/2022 **Status:** ✅ Merged **Merged:** 4/25/2022 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `fix-8941` --- ### 📝 Commits (1) - [`a91c46b`](https://github.com/netbox-community/netbox/commit/a91c46b4c0d61841321f8e331979a09d092380bf) UI: Fix apiSelect scrolling while zoomed in chrome ### 📊 Changes **3 files changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/project-static/dist/netbox.js` (+1 -1) 📝 `netbox/project-static/dist/netbox.js.map` (+1 -1) 📝 `netbox/project-static/src/select/api/apiSelect.ts` (+2 -1) </details> ### 📄 Description ### Fixes: #8941 Just Math.floor() scrollTop so that the strict comparison has a chance to match when chrome returns fractions when zoomed at 110% and 67%. Tested a bunch of different zoom levels, seems to work as intended. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:27:26 +01:00
adam closed this issue 2025-12-29 22:27:26 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13441
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?