starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Change "Interface" to "Tunnel interface" in tunnel termination form #9046

New Issue
Closed
opened 2025-12-29 20:44:47 +01:00 by adam · 1 comment
adam commented 2025-12-29 20:44:47 +01:00
Owner
Copy Link

Originally created by @markkuleinio on GitHub (Jan 5, 2024).

Originally assigned to: @markkuleinio on GitHub.

NetBox version

v3.7.0

Feature type

Change to existing functionality

Proposed functionality

I'm proposing changing the "Interface" field to "Tunnel interface" in the VPN tunnel termination form.

Use case

The current terminology talking about "tunnel termination" and then asking for interface hints the user that this is the actual tunnel starting point (outside interface).

However, the real purpose of the field is to designate the route-based tunnel interface (inside interface), not the tunnel source/destination (outside) interface. This is somewhat confusing, especially when the next field is called "Outside IP" that definitely talks about the tunnel outside interface. (That's logical thinking in other cases for me at least: first you select interface, then you select the IP of that interface)

Example issue of the current confusion is #14681.

Renaming the interface field to "Tunnel interface" would guide the user to use the tunnel (inside) interface, not the outside interface.

Database changes

Not sure if this naming change should involve changing some internal structures as well

External dependencies

No response

Originally created by @markkuleinio on GitHub (Jan 5, 2024). Originally assigned to: @markkuleinio on GitHub. ### NetBox version v3.7.0 ### Feature type Change to existing functionality ### Proposed functionality I'm proposing changing the "**Interface**" field to "**Tunnel interface**" in the VPN tunnel termination form. ### Use case The current terminology talking about "tunnel termination" and then asking for **interface** hints the user that this is the actual tunnel starting point (outside interface). However, the real purpose of the field is to designate the **route-based tunnel interface** (inside interface), not the tunnel source/destination (outside) interface. This is somewhat confusing, especially when the next field is called "Outside IP" that definitely talks about the tunnel outside interface. (That's logical thinking in other cases for me at least: first you select interface, then you select the IP of that interface) Example issue of the current confusion is #14681. Renaming the interface field to "**Tunnel interface**" would guide the user to use the tunnel (inside) interface, not the outside interface. ### Database changes Not sure if this naming change should involve changing some internal structures as well ### External dependencies _No response_
adam added the status: acceptedtype: feature labels 2025-12-29 20:44:47 +01:00
adam closed this issue 2025-12-29 20:44:47 +01:00
adam commented 2025-12-29 20:44:48 +01:00
Author
Owner
Copy Link

@jeffgdotorg commented on GitHub (Apr 3, 2024):

If I've understood your proposal correctly, this change can be made without model changes, just a wording change to the tunnel termination creation form. Go ahead with a PR if you agree.

@jeffgdotorg commented on GitHub (Apr 3, 2024): If I've understood your proposal correctly, this change can be made without model changes, just a wording change to the tunnel termination creation form. Go ahead with a PR if you agree.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#9046
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?