starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #15792] [MERGED] 15789 make sure job completed before including config_form #14681

New Issue
Closed
opened 2025-12-29 23:25:56 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:25:56 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/15792
Author: @arthanson
Created: 4/20/2024
Status: ✅ Merged
Merged: 4/21/2024
Merged by: @jeremystretch

Base: feature ← Head: 15789-run-script

📝 Commits (1)

  • 92b026c 15789 make sure job completed before including config_form

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 netbox/templates/extras/script_result.html (+2 -0)

📄 Description

Fixes: #15789

If the job isn't completed then there is no table, which is accounted for in the rest of the form but not for the include of the config_form. Was a bit tricky as timing related, if the job finishes before display then it works fine.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/15792 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 4/20/2024 **Status:** ✅ Merged **Merged:** 4/21/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `15789-run-script` --- ### 📝 Commits (1) - [`92b026c`](https://github.com/netbox-community/netbox/commit/92b026cd2b30ed2c28f9dc16bf375367f54259c7) 15789 make sure job completed before including config_form ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/templates/extras/script_result.html` (+2 -0) </details> ### 📄 Description ### Fixes: #15789 If the job isn't completed then there is no table, which is accounted for in the rest of the form but not for the include of the config_form. Was a bit tricky as timing related, if the job finishes before display then it works fine. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:25:56 +01:00
adam closed this issue 2025-12-29 23:25:56 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14681
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?