starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Specifying a site during the creation or import of a prefix prevents seleting a VLAN unassigned to a site #8070

New Issue
Closed
opened 2025-12-29 20:31:55 +01:00 by adam · 8 comments
adam commented 2025-12-29 20:31:55 +01:00
Owner
Copy Link

Originally created by @dhenschen on GitHub (May 16, 2023).

Originally assigned to: @dhenschen on GitHub.

NetBox version

v3.5.1

Python version

3.10

Steps to Reproduce

Steps for reproducing creating a new Prefix:

  1. Login to the netbox Demo site at https://demo.netbox.dev
  2. Import the following VLAN from with the YAML format under IPAM > VLANS > VLANs > Import
vid: 1000
name: management
status: active
  1. Create a new Prefix from IPAM > PREFIXES > Prefixes > Add.
  2. Set the Prefix field to 10.1.0.0/24
  3. Set the Site field to DM-Akron
  4. Look for the new management VLAN in the filtered VLAN set. The vlan is not listed when it seems like it should be since it is not assigned to a site

Steps for reproducing importing a new Prefix:

  1. Login to the netbox Demo site at https://demo.netbox.dev
  2. Import the following VLAN from with the YAML format under IPAM > VLANS > VLANs > Import
vid: 1000
name: management
status: active
  1. Import a new Prefix from IPAM > PREFIXES > Prefixes > Import with the following YAML
prefix: 10.1.1.0/24
status: active
site: DM-Akron
vlan: 1000

Expected Behavior

For both creation and import, I expect to be able to assign VLANs from the same site as the prefix or VLANs without a site assignment. This is the same expectation found in issue https://github.com/netbox-community/netbox/issues/11619.

Observed Behavior

  • For the creation, any vlan without a site assigned is not available for selection if the prefix is assigned a site. However, If one sets the vlan before setting the site, the management vlan can be set during creation. This work around is not convenient or intuitive to users.
  • For the import a toast pops up in the UI that states Record 1 vlan: Object not found: 1000

This is similar to https://github.com/netbox-community/netbox/issues/11619, but it impacts the IPAM app instead of DCIM. I felt that the root cause and fix was different enough that it warranted a separate issue.

I'm interesting in working this issue if it is approved.

Originally created by @dhenschen on GitHub (May 16, 2023). Originally assigned to: @dhenschen on GitHub. ### NetBox version v3.5.1 ### Python version 3.10 ### Steps to Reproduce Steps for reproducing creating a new Prefix: 1. Login to the netbox Demo site at https://demo.netbox.dev 2. Import the following VLAN from with the YAML format under IPAM > VLANS > VLANs > Import ```yaml vid: 1000 name: management status: active ``` 3. Create a new Prefix from IPAM > PREFIXES > Prefixes > Add. 4. Set the Prefix field to `10.1.0.0/24` 5. Set the Site field to `DM-Akron` 6. Look for the new management VLAN in the filtered VLAN set. The vlan is not listed when it seems like it should be since it is not assigned to a site --- Steps for reproducing importing a new Prefix: 1. Login to the netbox Demo site at https://demo.netbox.dev 2. Import the following VLAN from with the YAML format under IPAM > VLANS > VLANs > Import ```yaml vid: 1000 name: management status: active ``` 3. Import a new Prefix from IPAM > PREFIXES > Prefixes > Import with the following YAML ```yaml prefix: 10.1.1.0/24 status: active site: DM-Akron vlan: 1000 ``` ### Expected Behavior For both creation and import, I expect to be able to assign VLANs from the same site as the prefix or VLANs without a site assignment. This is the same expectation found in issue https://github.com/netbox-community/netbox/issues/11619. ### Observed Behavior - For the creation, any vlan without a site assigned is not available for selection if the prefix is assigned a site. However, If one sets the vlan before setting the site, the management vlan can be set during creation. This work around is not convenient or intuitive to users. - For the import a toast pops up in the UI that states `Record 1 vlan: Object not found: 1000` This is similar to https://github.com/netbox-community/netbox/issues/11619, but it impacts the IPAM app instead of DCIM. I felt that the root cause and fix was different enough that it warranted a separate issue. I'm interesting in working this issue if it is approved.
adam added the type: bugstatus: accepted labels 2025-12-29 20:31:55 +01:00
adam closed this issue 2025-12-29 20:31:55 +01:00
adam commented 2025-12-29 20:31:55 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (May 16, 2023):

The simple solution is to switch to the selectors for filtering.

This might require some backend changes through as well.

@DanSheps commented on GitHub (May 16, 2023): The simple solution is to switch to the selectors for filtering. This might require some backend changes through as well.
adam commented 2025-12-29 20:31:55 +01:00
Author
Owner
Copy Link

@dhenschen commented on GitHub (May 17, 2023):

Possible Feature Request

@DanSheps , I appreciate your suggestion. I elaborated on my thoughts in next two sections below.

Benefits of VLAN Selector

I believe implementing a selector similar to the site selector could enhance the user experience and address another issue outlined below.

Currently, when creating a prefix without specifying a site, the filter dialog displays all VLANs that match, without providing any context about the site they belong to. This lack of context can make it challenging for users to determine the VLAN they actually want to assign, especially when there are overlaps in names and vids. Below is an example of this from the demo data.
image

By adopting a selector approach similar to the site selector, we can provide users with the necessary information and context to make informed decisions when selecting VLANs for their prefixes.

Downsides of VLAN Selector

However, this above example could be mitigated by the user choosing a site before selecting the VLAN. Adding a selector may require some additional verification checks to make sure the VLAN selection and site selection do not contradict.

I did a test and it doesn't look like there is any current checks in NetBox to ensure that the site of a VLAN matches the site of a Prefix.

  1. Create a new Prefix from IPAM > PREFIXES > Prefixes > Add.
  2. Set the Prefix field to 10.1.0.0/24
  3. Set the Site field to DM-Akron
  4. Set the Site field to the Data (100) VLAN of DM-Akron
  5. Set the Site field to DM-Binghamton
  6. Click Create

This creates a prefix belonging to New York / DM-Binghamton, but the vlan belongs to Ohio / DM-Akron. One is able to create this mismatch in v3.5.1.

Current Bugfix

It is possible to fix this bug by enhancing some existing query filters. I opened the following draft pull request to outline the needed changes: https://github.com/netbox-community/netbox/pull/12634

@dhenschen commented on GitHub (May 17, 2023): ## Possible Feature Request @DanSheps , I appreciate your suggestion. I elaborated on my thoughts in next two sections below. ### Benefits of VLAN Selector I believe implementing a selector similar to the site selector could enhance the user experience and address another issue outlined below. Currently, when creating a prefix without specifying a site, the filter dialog displays all VLANs that match, without providing any context about the site they belong to. This lack of context can make it challenging for users to determine the VLAN they actually want to assign, especially when there are overlaps in names and vids. Below is an example of this from the demo data. ![image](https://github.com/netbox-community/netbox/assets/11417982/ce14edfe-67e6-432e-86f3-73980956b665) By adopting a selector approach similar to the site selector, we can provide users with the necessary information and context to make informed decisions when selecting VLANs for their prefixes. ### Downsides of VLAN Selector However, this above example could be mitigated by the user choosing a site before selecting the VLAN. Adding a selector may require some additional verification checks to make sure the VLAN selection and site selection do not contradict. I did a test and it doesn't look like there is any current checks in NetBox to ensure that the site of a VLAN matches the site of a Prefix. 1. Create a new Prefix from IPAM > PREFIXES > Prefixes > Add. 2. Set the Prefix field to `10.1.0.0/24` 3. Set the Site field to `DM-Akron` 4. Set the Site field to the `Data (100)` VLAN of `DM-Akron` 5. Set the Site field to `DM-Binghamton` 6. Click Create This creates a prefix belonging to `New York / DM-Binghamton`, but the vlan belongs to `Ohio / DM-Akron`. One is able to create this mismatch in v3.5.1. ## Current Bugfix It is possible to fix this bug by enhancing some existing query filters. I opened the following draft pull request to outline the needed changes: https://github.com/netbox-community/netbox/pull/12634
adam commented 2025-12-29 20:31:56 +01:00
Author
Owner
Copy Link

@dhenschen commented on GitHub (May 25, 2023):

If this issue is accepted, I would like to take ownership of it.

I've implemented a fix for the current filter UI that would resolve the bug discussed in this issue. See https://github.com/netbox-community/netbox/pull/12634 I also implemented the addition of the selector. See my comment below.

As for the bigger selector discussion, I think that could also be addressed as part of this issue in a separate PR. However, I'd like to see the bug addressed first. I thought the scope of the selector was going to be a significantly larger change. It turns out I am wrong. Please see the comment below.

@dhenschen commented on GitHub (May 25, 2023): If this issue is accepted, I would like to take ownership of it. ~~I've implemented a fix for the current filter UI that would resolve the bug discussed in this issue. See https://github.com/netbox-community/netbox/pull/12634~~ I also implemented the addition of the selector. See my comment below. ~~As for the bigger selector discussion, I think that could also be addressed as part of this issue in a separate PR. However, I'd like to see the bug addressed first.~~ I thought the scope of the selector was going to be a significantly larger change. It turns out I am wrong. Please see the comment below.
adam commented 2025-12-29 20:31:56 +01:00
Author
Owner
Copy Link

@dhenschen commented on GitHub (May 26, 2023):

@DanSheps, I've discovered that the changes to implement a selector are extremely simple as you stated in your previous comment. Based on the work already completed in https://github.com/netbox-community/netbox/pull/11952/files, the diff to add a selector for VLAN in the prefix creation UI (IPAM > PREFIXES > Prefixes > Add) is as follows:

diff --git a/netbox/ipam/forms/model_forms.py b/netbox/ipam/forms/model_forms.py
index cf8117bf7..a4af2ad19 100644
--- a/netbox/ipam/forms/model_forms.py
+++ b/netbox/ipam/forms/model_forms.py
@@ -211,10 +211,8 @@ class PrefixForm(TenancyForm, NetBoxModelForm):
     vlan = DynamicModelChoiceField(
         queryset=VLAN.objects.all(),
         required=False,
+        selector=True,
         label=_('VLAN'),
-        query_params={
-            'site_id': '$site',
-        }
     )
     role = DynamicModelChoiceField(
         queryset=Role.objects.all(),

I tested this locally off of the develop branch and it accomplishes exactly what I'd like to see from this reported bug. Below is a screenshot created by following Steps to Reproduce included in this issue description.

image

@MarcHagen I think this change would also address what you reported in issue: https://github.com/netbox-community/netbox/issues/12619

image

I have the changes on saved on a local branch of my fork. I would be interested in opening a Pull Request to implement this selector. See https://github.com/dhenschen/netbox/tree/12622-fix-assigning-vlan-without-site-to-prefix

@dhenschen commented on GitHub (May 26, 2023): @DanSheps, I've discovered that the changes to implement a selector are **_extremely_** simple as you stated in your previous comment. Based on the work already completed in https://github.com/netbox-community/netbox/pull/11952/files, the diff to add a selector for VLAN in the prefix creation UI (IPAM > PREFIXES > Prefixes > Add) is as follows: ```diff diff --git a/netbox/ipam/forms/model_forms.py b/netbox/ipam/forms/model_forms.py index cf8117bf7..a4af2ad19 100644 --- a/netbox/ipam/forms/model_forms.py +++ b/netbox/ipam/forms/model_forms.py @@ -211,10 +211,8 @@ class PrefixForm(TenancyForm, NetBoxModelForm): vlan = DynamicModelChoiceField( queryset=VLAN.objects.all(), required=False, + selector=True, label=_('VLAN'), - query_params={ - 'site_id': '$site', - } ) role = DynamicModelChoiceField( queryset=Role.objects.all(), ``` I tested this locally off of the develop branch and it accomplishes exactly what I'd like to see from this reported bug. Below is a screenshot created by following **Steps to Reproduce** included in this issue description. ![image](https://github.com/netbox-community/netbox/assets/11417982/6ec00bea-3128-4edd-a590-5c258fa79e00) @MarcHagen I think this change would also address what you reported in issue: https://github.com/netbox-community/netbox/issues/12619 ![image](https://github.com/netbox-community/netbox/assets/11417982/d9355dae-5c34-404b-9791-ee5a4b171f7e) I have the changes on saved on a local branch of my fork. I would be interested in opening a Pull Request to implement this selector. See https://github.com/dhenschen/netbox/tree/12622-fix-assigning-vlan-without-site-to-prefix
adam commented 2025-12-29 20:31:57 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (May 26, 2023):

Would you like to implement the changes?

@DanSheps commented on GitHub (May 26, 2023): Would you like to implement the changes?
adam commented 2025-12-29 20:31:57 +01:00
Author
Owner
Copy Link

@dhenschen commented on GitHub (May 27, 2023):

@DanSheps Yes, I would like to implement the changes. Thanks!

@dhenschen commented on GitHub (May 27, 2023): @DanSheps Yes, I would like to implement the changes. Thanks!
adam commented 2025-12-29 20:31:57 +01:00
Author
Owner
Copy Link

@ITJamie commented on GitHub (May 29, 2023):

This would also solve the issue we have just found where the removal of the vlan_groups from the prefix model makes it hard to find the correct vlan to assign a prefix to on a site with many prefixes with the same vid or name

@ITJamie commented on GitHub (May 29, 2023): This would also solve the issue we have just found where the removal of the vlan_groups from the prefix model makes it hard to find the correct vlan to assign a prefix to on a site with many prefixes with the same vid or name
adam commented 2025-12-29 20:31:57 +01:00
Author
Owner
Copy Link

@MarcHagen commented on GitHub (Jun 14, 2023):

@dhenschen Thank you!

@MarcHagen commented on GitHub (Jun 14, 2023): @dhenschen Thank you!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8070
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?