starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #8070] [MERGED] Closes #8069: Generic children view #13312

New Issue
Closed
opened 2025-12-29 22:26:42 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:26:42 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/8070
Author: @jeremystretch
Created: 12/14/2021
Status: ✅ Merged
Merged: 12/14/2021
Merged by: @jeremystretch

Base: develop ← Head: 8069-generic-children-view

📝 Commits (6)

  • af6f0db Introduce ObjectChildrenView
  • cfdb985 Update prefix children views to use ObjectChildrenView
  • 8d3b296 Update device/VM component views to use ObjectChildrenView
  • 5ce0807 Update IPRange IP addresses view to use ObjectChildrenView
  • c795068 Update VLAN member interface views to use ObjectChildrenView
  • 59ee30f Update cluster VM/device views to use ObjectChildrenView

📊 Changes

10 files changed (+142 additions, -178 deletions)

View changed files

📝 netbox/dcim/views.py (+25 -36)
📝 netbox/ipam/views.py (+44 -105)
📝 netbox/netbox/views/generic.py (+48 -0)
📝 netbox/templates/ipam/iprange/ip_addresses.html (+1 -1)
📝 netbox/templates/ipam/vlan/interfaces.html (+1 -1)
📝 netbox/templates/ipam/vlan/vminterfaces.html (+1 -1)
📝 netbox/templates/virtualization/cluster/devices.html (+1 -1)
📝 netbox/templates/virtualization/cluster/virtual_machines.html (+1 -1)
📝 netbox/templates/virtualization/virtualmachine/interfaces.html (+2 -2)
📝 netbox/virtualization/views.py (+18 -30)

📄 Description

Closes: #8069

  • Introduces ObjectChildrenView generic view
  • Updates all "tabbed" object views to use this

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/8070 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 12/14/2021 **Status:** ✅ Merged **Merged:** 12/14/2021 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `8069-generic-children-view` --- ### 📝 Commits (6) - [`af6f0db`](https://github.com/netbox-community/netbox/commit/af6f0db2844cf3d0c9640142f29055895eeeab52) Introduce ObjectChildrenView - [`cfdb985`](https://github.com/netbox-community/netbox/commit/cfdb985d008a4ee52bbda6addc8fd1ad2720e776) Update prefix children views to use ObjectChildrenView - [`8d3b296`](https://github.com/netbox-community/netbox/commit/8d3b296eed141e75af86ef8137e8433d46ef1508) Update device/VM component views to use ObjectChildrenView - [`5ce0807`](https://github.com/netbox-community/netbox/commit/5ce080779b2178b78f12bb10aac7ff3b564950a3) Update IPRange IP addresses view to use ObjectChildrenView - [`c795068`](https://github.com/netbox-community/netbox/commit/c795068a78cc24a17f98ef5c8f55218521c0d663) Update VLAN member interface views to use ObjectChildrenView - [`59ee30f`](https://github.com/netbox-community/netbox/commit/59ee30f0561658a1d39f5f3c0791a7eff2ee9023) Update cluster VM/device views to use ObjectChildrenView ### 📊 Changes **10 files changed** (+142 additions, -178 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/views.py` (+25 -36) 📝 `netbox/ipam/views.py` (+44 -105) 📝 `netbox/netbox/views/generic.py` (+48 -0) 📝 `netbox/templates/ipam/iprange/ip_addresses.html` (+1 -1) 📝 `netbox/templates/ipam/vlan/interfaces.html` (+1 -1) 📝 `netbox/templates/ipam/vlan/vminterfaces.html` (+1 -1) 📝 `netbox/templates/virtualization/cluster/devices.html` (+1 -1) 📝 `netbox/templates/virtualization/cluster/virtual_machines.html` (+1 -1) 📝 `netbox/templates/virtualization/virtualmachine/interfaces.html` (+2 -2) 📝 `netbox/virtualization/views.py` (+18 -30) </details> ### 📄 Description ### Closes: #8069 - Introduces ObjectChildrenView generic view - Updates all "tabbed" object views to use this --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:26:42 +01:00
adam closed this issue 2025-12-29 22:26:43 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13312
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?