Return to circuit after editing termination #7088

New Issue

adam · 2025-12-29T20:19:04+01:00

adam commented

2025-12-29 20:19:04 +01:00

Originally created by @PieterL75 on GitHub (Oct 7, 2022).

NetBox version

v3.2.9

Python version

3.9

Steps to Reproduce

Create a circuit
in the circuit page, create a termination (returns properly to the circuit)
in the circuit page, edit the termination and save

Expected Behavior

The edit page returns to the circuit or site

Observed Behavior

The edit page returns to the termination details, rather than the ciruit

Originally created by @PieterL75 on GitHub (Oct 7, 2022). ### NetBox version v3.2.9 ### Python version 3.9 ### Steps to Reproduce 1. Create a circuit 2. in the circuit page, create a termination (returns properly to the circuit) 3. in the circuit page, edit the termination and save ### Expected Behavior The edit page returns to the circuit or site ### Observed Behavior The edit page returns to the termination details, rather than the ciruit

adam added the type: bug status: revisions needed labels 2025-12-29 20:19:04 +01:00

adam closed this issue

2025-12-29 20:19:04 +01:00

adam commented

2025-12-29 20:19:05 +01:00

@jeremystretch commented on GitHub (Oct 7, 2022):

The edit page returns to the termination details, rather than the ciruit

I'm not able to reproduce this. Upon editing the circuit termination, I'm returned to the circuit view as expected. Additionally, there is no circuit termination detail view.

@jeremystretch commented on GitHub (Oct 7, 2022): > The edit page returns to the termination details, rather than the ciruit I'm not able to reproduce this. Upon editing the circuit termination, I'm returned to the circuit view as expected. Additionally, there is no circuit termination detail view.

adam commented

2025-12-29 20:19:05 +01:00

@PieterL75 commented on GitHub (Oct 7, 2022):

How bizar. On the demo instance it also works as expected. Going to look further on the exact steps I take to get this behavior

P

@PieterL75 commented on GitHub (Oct 7, 2022): How bizar. On the demo instance it also works as expected. Going to look further on the exact steps I take to get this behavior P

adam commented

2025-12-29 20:19:05 +01:00

@PieterL75 commented on GitHub (Oct 10, 2022):

I'm still running v3.2.9 and not 3.3
in 3.2.9, the edit button has this : https://netbox/circuits/circuit-terminations/2/edit/
while in 3.3.5, the url says https://netbox/circuits/circuit-terminations/2/edit/?return_url=/circuits/circuits/3/

It was added here a5124ab9c8 (diff-b5dc17ee33380308d801286d162870c4173b3f2c0180ee510acdf895720537f6) by #8511
but maybe the
https://github.com/netbox-community/netbox/blob/develop/netbox/circuits/models/circuits.py#L216
get_absolute_url needs an update ?

@PieterL75 commented on GitHub (Oct 10, 2022): I'm still running v3.2.9 and not 3.3 in 3.2.9, the edit button has this : https://netbox/circuits/circuit-terminations/2/edit/ while in 3.3.5, the url says https://netbox/circuits/circuit-terminations/2/edit/?return_url=/circuits/circuits/3/ It was added here https://github.com/netbox-community/netbox/commit/a5124ab9c835896ff434812bf870d1add82a3afe#diff-b5dc17ee33380308d801286d162870c4173b3f2c0180ee510acdf895720537f6 by #8511 but maybe the https://github.com/netbox-community/netbox/blob/develop/netbox/circuits/models/circuits.py#L216 get_absolute_url needs an update ?

adam commented

2025-12-29 20:19:06 +01:00

@PieterL75 commented on GitHub (Oct 13, 2022):

What I now noticed too :
a Termination in a table, is linked to the 'Site' or the 'Provider network.
That seems good, as long as the termination is not connected to a real port.
If the termination is connected to a Port, then the get_absolute_url should return the port/interface/device it is connected to.

Or we should be able to get 2 separate columns.. one with 'Termination site/provider' and another with 'Termination port/device'

@PieterL75 commented on GitHub (Oct 13, 2022): What I now noticed too : a Termination in a table, is linked to the 'Site' or the 'Provider network. That seems good, as long as the termination is not connected to a real port. If the termination is connected to a Port, then the get_absolute_url should return the port/interface/device it is connected to. Or we should be able to get 2 separate columns.. one with 'Termination site/provider' and another with 'Termination port/device'

adam commented

2025-12-29 20:19:06 +01:00

@jeremystretch commented on GitHub (Oct 14, 2022):

@PieterL75 possibly; we can discuss that under a separate FR.

I'm going to close this issue as the reported issue cannot be reproduced on the current release AFAICT.

@jeremystretch commented on GitHub (Oct 14, 2022): @PieterL75 possibly; we can discuss that under a separate FR. I'm going to close this issue as the reported issue cannot be reproduced on the current release AFAICT.

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#7088