starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Optimize the declaration of view actions #8511

New Issue
Closed
opened 2025-12-29 20:37:36 +01:00 by adam · 0 comments
adam commented 2025-12-29 20:37:36 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Aug 24, 2023).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

ActionsMixin defines two attributes on a view:

  • actions - A tuple of support action names
  • action_perms - A dictionary mapping of action names to a set of required permissions for each

The following actions are defined by default:

    actions = ('add', 'import', 'export', 'bulk_edit', 'bulk_delete')
    action_perms = defaultdict(set, **{
        'add': {'add'},
        'import': {'add'},
        'bulk_edit': {'change'},
        'bulk_delete': {'delete'},
    })

These can be combined into a single mapping:

    actions = {
        'add': {'add'},
        'import': {'add'},
        'export': set(),
        'bulk_edit': {'change'},
        'bulk_delete': {'delete'},
    }

Justification

This change will simplify the list of support actions for a view and reduce duplicate code.

Originally created by @jeremystretch on GitHub (Aug 24, 2023). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes `ActionsMixin` defines two attributes on a view: * `actions` - A tuple of support action names * `action_perms` - A dictionary mapping of action names to a set of required permissions for each The following actions are defined by default: ```python actions = ('add', 'import', 'export', 'bulk_edit', 'bulk_delete') action_perms = defaultdict(set, **{ 'add': {'add'}, 'import': {'add'}, 'bulk_edit': {'change'}, 'bulk_delete': {'delete'}, }) ``` These can be combined into a single mapping: ```python actions = { 'add': {'add'}, 'import': {'add'}, 'export': set(), 'bulk_edit': {'change'}, 'bulk_delete': {'delete'}, } ``` ### Justification This change will simplify the list of support actions for a view and reduce duplicate code.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 20:37:36 +01:00
adam closed this issue 2025-12-29 20:37:36 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#8511
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?