starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Multi-value filters should run validate() on each value #7057

New Issue
Closed
opened 2025-12-29 19:48:27 +01:00 by adam · 0 comments
adam commented 2025-12-29 19:48:27 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Sep 30, 2022).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

We use multivalue_field_factory() to generate filters that accept multiple values, to support querying for e.g. ?status=a&status=b (applying an OR logic). However, these filters are not properly validating the passed values. The class returned by multivalue_field_factory() should have its run_validators() and validate() methods overriden so that they execute on each value in the list.

Justification

This problem was originally uncovered by @arthanson while working on #10348. I've broken it into a separate issue for explicit tracking of the change, as it affects all multi-value filters.

Originally created by @jeremystretch on GitHub (Sep 30, 2022). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes We use [`multivalue_field_factory()`]() to generate filters that accept multiple values, to support querying for e.g. `?status=a&status=b` (applying an OR logic). However, these filters are not properly validating the passed values. The class returned by `multivalue_field_factory()` should have its `run_validators()` and `validate()` methods overriden so that they execute on each value in the list. ### Justification This problem was originally uncovered by @arthanson while working on #10348. I've broken it into a separate issue for explicit tracking of the change, as it affects all multi-value filters.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 19:48:27 +01:00
adam closed this issue 2025-12-29 19:48:27 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#7057
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?