starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Audit & clean up import statements application-wide #10348

New Issue
Closed
opened 2025-12-29 21:30:22 +01:00 by adam · 1 comment
adam commented 2025-12-29 21:30:22 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Oct 10, 2024).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

Audit the code base with ruff to clean up import statements:

  • Remove unused imports (F401)
  • Replace wildcard (*) imports with explicit lists (F403, F405)

Justification

General housekeeping and improvements to code quality

Originally created by @jeremystretch on GitHub (Oct 10, 2024). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes Audit the code base with [ruff](https://docs.astral.sh/ruff/) to clean up import statements: * Remove unused imports ([F401](https://docs.astral.sh/ruff/rules/unused-import/)) * ~Replace wildcard (`*`) imports with explicit lists ([F403](https://docs.astral.sh/ruff/rules/undefined-local-with-import-star/), [F405](https://docs.astral.sh/ruff/rules/undefined-local-with-import-star-usage/))~ ### Justification General housekeeping and improvements to code quality
adam added the status: acceptedtype: housekeeping labels 2025-12-29 21:30:22 +01:00
adam closed this issue 2025-12-29 21:30:22 +01:00
adam commented 2025-12-29 21:30:22 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Oct 10, 2024):

It doesn't seem that there's sufficient tangible benefit of removing wildcard imports to justify the effort involved. Instead, we could simply ensure that any module which is imported using a wildcard declares __all__, to ensure only expected resources are imported. (This is already true for most relevant modules.)

@jeremystretch commented on GitHub (Oct 10, 2024): It doesn't seem that there's sufficient tangible benefit of removing wildcard imports to justify the effort involved. Instead, we could simply ensure that any module which is imported using a wildcard declares `__all__`, to ensure only expected resources are imported. (This is already true for most relevant modules.)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10348
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?