starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Plugin template extensions missing from VM interface view #4256

New Issue
Closed
opened 2025-12-29 18:34:16 +01:00 by adam · 2 comments
adam commented 2025-12-29 18:34:16 +01:00
Owner
Copy Link

Originally created by @minitriga on GitHub (Nov 9, 2020).

Originally assigned to: @jeremystretch on GitHub.

I'm currently writing netbox_graphs for the inevitable removal of graphs in 2.10 I have graphs functioning in Sites, Devices and Providers to keep the existing functionality of the current graph implementation but some templates do not support plugin buttons.

Environment

  • Python version: Python 3.7.7
  • NetBox version: v2.9.7

Steps to Reproduce

  1. Create template_content.py and add the following:
## Does not work needs fixing
class VirtualizationVMIntfGraphButton(PluginTemplateExtension):
    model = 'virtualization.vminterface'

    def buttons(self):
        return button_template(self)

## Does not work needs fixing
class IntfGraphButton(PluginTemplateExtension):
    model = 'dcim.interface'

    def button(self):
        return button_template(self)

template_extensions = [VirtualizationVMIntfGraphButton, IntfGraphButton]
  1. Buttons do not load due to vminterface.html and interface.html not containing plugin buttons.

Expected Behavior

Expected buttons to load.

Observed Behavior

No buttons are loaded.

Originally created by @minitriga on GitHub (Nov 9, 2020). Originally assigned to: @jeremystretch on GitHub. I'm currently writing netbox_graphs for the inevitable removal of graphs in `2.10` I have graphs functioning in Sites, Devices and Providers to keep the existing functionality of the current graph implementation but some templates do not support plugin buttons. ### Environment * Python version: Python 3.7.7 * NetBox version: v2.9.7 <!-- Describe in detail the exact steps that someone else can take to reproduce this bug using the current stable release of NetBox. Begin with the creation of any necessary database objects and call out every operation being performed explicitly. If reporting a bug in the REST API, be sure to reconstruct the raw HTTP request(s) being made: Don't rely on a client library such as pynetbox. --> ### Steps to Reproduce 1. Create template_content.py and add the following: ```python ## Does not work needs fixing class VirtualizationVMIntfGraphButton(PluginTemplateExtension): model = 'virtualization.vminterface' def buttons(self): return button_template(self) ## Does not work needs fixing class IntfGraphButton(PluginTemplateExtension): model = 'dcim.interface' def button(self): return button_template(self) template_extensions = [VirtualizationVMIntfGraphButton, IntfGraphButton] ``` 2. Buttons do not load due to `vminterface.html` and `interface.html` not containing plugin buttons. <!-- What did you expect to happen? --> ### Expected Behavior Expected buttons to load. <!-- What happened instead? --> ### Observed Behavior No buttons are loaded.
adam added the type: bugstatus: accepted labels 2025-12-29 18:34:16 +01:00
adam closed this issue 2025-12-29 18:34:16 +01:00
adam commented 2025-12-29 18:34:17 +01:00
Author
Owner
Copy Link

@minitriga commented on GitHub (Nov 9, 2020):

#4349

Its very basic at the moment but here is the initial run through. https://github.com/minitriga/netbox-graphs

@minitriga commented on GitHub (Nov 9, 2020): #4349 Its very basic at the moment but here is the initial run through. https://github.com/minitriga/netbox-graphs
adam commented 2025-12-29 18:34:17 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Nov 9, 2020):

Looks like the vminterface.html template never had the plugin_* template tags added to it for some reason.

## Does not work needs fixing
class IntfGraphButton(PluginTemplateExtension):
    model = 'dcim.interface'

    def button(self):
        return button_template(self)

def button() should be def buttons(), plural. Correcting this will render the content as expected.

@jeremystretch commented on GitHub (Nov 9, 2020): Looks like the `vminterface.html` template never had the `plugin_*` template tags added to it for some reason. ``` ## Does not work needs fixing class IntfGraphButton(PluginTemplateExtension): model = 'dcim.interface' def button(self): return button_template(self) ``` `def button()` should be `def buttons()`, plural. Correcting this will render the content as expected.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#4256
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?