starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Plugin validation fails for required version, settings #4349

New Issue
Closed
opened 2025-12-29 18:35:05 +01:00 by adam · 0 comments
adam commented 2025-12-29 18:35:05 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Dec 11, 2020).

Originally assigned to: @jeremystretch on GitHub.

Environment

  • Python version: 3.6.9
  • NetBox version: 2.9.10

Steps to Reproduce

  1. Create and enable a plugin with at least one item defined in required_settings.
  2. Don't define that setting for the plugin in configuration.py.
  3. Run NetBox

Expected Behavior

NetBox should raise an ImproperlyConfigured exception complaining about the missing setting.

Observed Behavior

No exception is raised. This is due a a somewhat strange bug where referencing settings within PluginConfig.validate() suppresses the exception.

Originally created by @jeremystretch on GitHub (Dec 11, 2020). Originally assigned to: @jeremystretch on GitHub. ### Environment * Python version: 3.6.9 * NetBox version: 2.9.10 ### Steps to Reproduce 1. Create and enable a plugin with at least one item defined in `required_settings`. 2. Don't define that setting for the plugin in `configuration.py`. 3. Run NetBox ### Expected Behavior NetBox should raise an ImproperlyConfigured exception complaining about the missing setting. ### Observed Behavior No exception is raised. This is due a a somewhat strange bug where referencing `settings` within `PluginConfig.validate()` suppresses the exception.
adam added the type: bugstatus: accepted labels 2025-12-29 18:35:05 +01:00
adam closed this issue 2025-12-29 18:35:05 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#4349
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?