starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Links not consistent on rack elevation #4086

New Issue
Closed
opened 2025-12-29 18:33:02 +01:00 by adam · 2 comments
adam commented 2025-12-29 18:33:02 +01:00
Owner
Copy Link

Originally created by @alanNutanix on GitHub (Sep 9, 2020).

Environment

  • Python version: 3.7.9
  • NetBox version: 2.9.3

Steps to Reproduce

  1. Go to any rack view
  2. Look at empty spots vs. populated spots

Expected Behavior

Expected ALL links to be relative. Those that are populated are not, those that are empty are.

Observed Behavior

Links that are populated pick up the WRONG behavior from the bug in django.
(Yes, this is related to #4953 which I believe should NOT be closed but this gives additional information to make it easier to close)

Originally created by @alanNutanix on GitHub (Sep 9, 2020). ### Environment * Python version: 3.7.9 * NetBox version: 2.9.3 ### Steps to Reproduce 1. Go to any rack view 2. Look at empty spots vs. populated spots <!-- What did you expect to happen? --> ### Expected Behavior Expected ALL links to be relative. Those that are populated are not, those that are empty are. <!-- What happened instead? --> ### Observed Behavior Links that are populated pick up the WRONG behavior from the bug in django. (Yes, this is related to #4953 which I believe should NOT be closed but this gives additional information to make it easier to close)
adam added the status: revisions needed label 2025-12-29 18:33:02 +01:00
adam closed this issue 2025-12-29 18:33:02 +01:00
adam commented 2025-12-29 18:33:02 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Sep 9, 2020):

Expected ALL links to be relative.

Per #4147 in v2.7.12, rack SVG links should be absolute URLs to facilitate the use of SVG images outside of the NetBox UI. Why would you expect them to be relative?

@jeremystretch commented on GitHub (Sep 9, 2020): > Expected ALL links to be relative. Per #4147 in v2.7.12, rack SVG links should be absolute URLs to facilitate the use of SVG images outside of the NetBox UI. Why would you expect them to be relative?
adam commented 2025-12-29 18:33:02 +01:00
Author
Owner
Copy Link

@alanNutanix commented on GitHub (Sep 9, 2020):

So that they worked the same as the rest of the links on the page when behind multiple proxies.

However, I discovered the problem with how to get multiple proxies to work.
The nginx.conf file I added the following to:

        proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
        proxy_set_header Host $http_host;

I am closing this issue, although I'll open a new one to put those in the sample nginx.conf

@alanNutanix commented on GitHub (Sep 9, 2020): So that they worked the same as the rest of the links on the page when behind multiple proxies. However, I discovered the problem with how to get multiple proxies to work. The nginx.conf file I added the following to: ``` proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; proxy_set_header Host $http_host; ``` I am closing this issue, although I'll open a new one to put those in the sample nginx.conf
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: revisions needed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#4086
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?