starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #4098] [MERGED] Closes #4086: Rename device component create/edit/delete URLs #12757

New Issue
Closed
opened 2025-12-29 22:23:27 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:23:27 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/4098
Author: @jeremystretch
Created: 2/5/2020
Status: ✅ Merged
Merged: 2/5/2020
Merged by: @jeremystretch

Base: develop ← Head: 4086-device-component-urls

📝 Commits (10+)

  • fca347e Reorder URLs
  • c1639b7 Move component bulk delete views to new URLs
  • 3e79b9d Add InterfaceTestCase for virtual machines
  • f805b57 Adapt BulkEditView to not require a parent object for device components
  • f8ce67c Tweak BulkEditView to improve handling of initial PK values
  • 57a0cf0 Fix component bulk edit views
  • 6b9fa5e Enable tests for component bulk edit views
  • 75906f7 Move component bulk creation views to new URLs
  • 0ad613e Enable bulk creation tests for device components
  • b0c0ad7 Adapt component creation forms to infer parent device/VM from initial or bound data

📊 Changes

17 files changed (+595 additions, -333 deletions)

View changed files

📝 netbox/dcim/forms.py (+64 -25)
📝 netbox/dcim/tests/test_views.py (+149 -61)
📝 netbox/dcim/urls.py (+44 -40)
📝 netbox/dcim/views.py (+8 -29)
📝 netbox/templates/dcim/device.html (+49 -29)
📝 netbox/templates/dcim/device_component_add.html (+3 -6)
📝 netbox/templates/virtualization/virtualmachine.html (+3 -3)
📝 netbox/templates/virtualization/virtualmachine_component_add.html (+1 -1)
📝 netbox/utilities/forms.py (+2 -6)
📝 netbox/utilities/testing/testcases.py (+85 -14)
📝 netbox/utilities/testing/utils.py (+0 -29)
📝 netbox/utilities/utils.py (+13 -0)
📝 netbox/utilities/views.py (+28 -47)
📝 netbox/virtualization/forms.py (+47 -35)
📝 netbox/virtualization/tests/test_views.py (+95 -1)
📝 netbox/virtualization/urls.py (+4 -3)
📝 netbox/virtualization/views.py (+0 -4)

📄 Description

Fixes: #4086

  • Rename all device component URLs so that they no longer require specifying a parent device
  • Add tests for bulk create/edit/delete functionality

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/4098 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 2/5/2020 **Status:** ✅ Merged **Merged:** 2/5/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `4086-device-component-urls` --- ### 📝 Commits (10+) - [`fca347e`](https://github.com/netbox-community/netbox/commit/fca347e49e50c4bcb4493fdae8eb846a141d81b6) Reorder URLs - [`c1639b7`](https://github.com/netbox-community/netbox/commit/c1639b778130f684b525acde484e124a99ee8260) Move component bulk delete views to new URLs - [`3e79b9d`](https://github.com/netbox-community/netbox/commit/3e79b9d26aab22f874507ac7ca623bdc1a9cbb32) Add InterfaceTestCase for virtual machines - [`f805b57`](https://github.com/netbox-community/netbox/commit/f805b577788ca3ca3f3f4d4905802812615e416e) Adapt BulkEditView to not require a parent object for device components - [`f8ce67c`](https://github.com/netbox-community/netbox/commit/f8ce67c69f01406b884fcf7dc3c1d84a392c8b87) Tweak BulkEditView to improve handling of initial PK values - [`57a0cf0`](https://github.com/netbox-community/netbox/commit/57a0cf0a3361c9e5ba8e0a1d63194753d37121fe) Fix component bulk edit views - [`6b9fa5e`](https://github.com/netbox-community/netbox/commit/6b9fa5e76f22343f54bc3aa19a282dd5475bda61) Enable tests for component bulk edit views - [`75906f7`](https://github.com/netbox-community/netbox/commit/75906f7591de19c15c4d12714189dbe3d5231bc5) Move component bulk creation views to new URLs - [`0ad613e`](https://github.com/netbox-community/netbox/commit/0ad613e6b4659f74a148bb63cde579749c5b0399) Enable bulk creation tests for device components - [`b0c0ad7`](https://github.com/netbox-community/netbox/commit/b0c0ad7c8277fa6e55abad584084f87a6655f096) Adapt component creation forms to infer parent device/VM from initial or bound data ### 📊 Changes **17 files changed** (+595 additions, -333 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/forms.py` (+64 -25) 📝 `netbox/dcim/tests/test_views.py` (+149 -61) 📝 `netbox/dcim/urls.py` (+44 -40) 📝 `netbox/dcim/views.py` (+8 -29) 📝 `netbox/templates/dcim/device.html` (+49 -29) 📝 `netbox/templates/dcim/device_component_add.html` (+3 -6) 📝 `netbox/templates/virtualization/virtualmachine.html` (+3 -3) 📝 `netbox/templates/virtualization/virtualmachine_component_add.html` (+1 -1) 📝 `netbox/utilities/forms.py` (+2 -6) 📝 `netbox/utilities/testing/testcases.py` (+85 -14) 📝 `netbox/utilities/testing/utils.py` (+0 -29) 📝 `netbox/utilities/utils.py` (+13 -0) 📝 `netbox/utilities/views.py` (+28 -47) 📝 `netbox/virtualization/forms.py` (+47 -35) 📝 `netbox/virtualization/tests/test_views.py` (+95 -1) 📝 `netbox/virtualization/urls.py` (+4 -3) 📝 `netbox/virtualization/views.py` (+0 -4) </details> ### 📄 Description ### Fixes: #4086 - Rename all device component URLs so that they no longer require specifying a parent device - Add tests for bulk create/edit/delete functionality --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:23:27 +01:00
adam closed this issue 2025-12-29 22:23:27 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12757
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?