starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-12 05:20:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Enable cookie-based sessions #2500

New Issue
Closed
opened 2025-12-29 18:19:25 +01:00 by adam · 4 comments
adam commented 2025-12-29 18:19:25 +01:00
Owner
Copy Link

Originally created by @kartiksubbarao on GitHub (Apr 8, 2019).

Environment

  • Python version: 3.5.1
  • NetBox version: 2.5.9

Proposed Functionality

Allow users to set SESSION_ENGINE to "django.contrib.sessions.backends.signed_cookies" as described here: https://docs.djangoproject.com/en/2.2/topics/http/sessions/#cookie-session-backend

Use Case

My use case is a high-availability configuration where a VIP (netbox.example.com) is managed by keepalived on a master and hot standby replica. Users point to netbox.example.com in their browser. With cookie-based sessions, if the master crashed and keepalived flipped the VIP over to the replica, user sessions could transparently continue for read operations. (Also see this thread on the mailing list: https://groups.google.com/d/msg/netbox-discuss/1tYF9d-wRl8/pfs1iAYOBAAJ)

Jeremy hinted at the possibility of exposing SESSION_ENGINE in the #2426 discussion. If this is practical to implement, I think it could be helpful for many users who want to deploy netbox in various ways.

Database Changes

I don't know if any database changes are required.

External Dependencies

I don't know if any external dependencies are introduced.

Originally created by @kartiksubbarao on GitHub (Apr 8, 2019). ### Environment * Python version: 3.5.1 * NetBox version: 2.5.9 ### Proposed Functionality Allow users to set SESSION_ENGINE to "django.contrib.sessions.backends.signed_cookies" as described here: https://docs.djangoproject.com/en/2.2/topics/http/sessions/#cookie-session-backend ### Use Case My use case is a high-availability configuration where a VIP (netbox.example.com) is managed by keepalived on a master and hot standby replica. Users point to netbox.example.com in their browser. With cookie-based sessions, if the master crashed and keepalived flipped the VIP over to the replica, user sessions could transparently continue for read operations. (Also see this thread on the mailing list: https://groups.google.com/d/msg/netbox-discuss/1tYF9d-wRl8/pfs1iAYOBAAJ) Jeremy hinted at the possibility of exposing SESSION_ENGINE in the #2426 discussion. If this is practical to implement, I think it could be helpful for many users who want to deploy netbox in various ways. ### Database Changes I don't know if any database changes are required. ### External Dependencies I don't know if any external dependencies are introduced.
adam closed this issue 2025-12-29 18:19:25 +01:00
adam commented 2025-12-29 18:19:25 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Apr 26, 2019):

I'd rather avoid cookie-based sessions for all the reasons listed in the Django documentation, foremost of which the performance implications. Although we don't currently store much in the way of session data, I expect that we will once we have the change to make some UI improvements (table column ordering, for example).

As an alternative, NetBox v2.6 will introduce support for caching (via Redis). It's probably worth exploring that as an alternative to database- and file-based session storage, but that would be a separate FR.

@jeremystretch commented on GitHub (Apr 26, 2019): I'd rather avoid cookie-based sessions for [all the reasons listed](https://docs.djangoproject.com/en/2.2/topics/http/sessions/#cookie-session-backend) in the Django documentation, foremost of which the performance implications. Although we don't currently store much in the way of session data, I expect that we will once we have the change to make some UI improvements (table column ordering, for example). As an alternative, NetBox v2.6 will introduce support for caching (via Redis). It's probably worth exploring that as an alternative to database- and file-based session storage, but that would be a separate FR.
adam commented 2025-12-29 18:19:25 +01:00
Author
Owner
Copy Link

@kartiksubbarao commented on GitHub (Apr 27, 2019):

Ok. Can you suggest any alternate ideas for fixing/working around the issues that people are seeing with #2426?

@kartiksubbarao commented on GitHub (Apr 27, 2019): Ok. Can you suggest any alternate ideas for fixing/working around the issues that people are seeing with #2426?
adam commented 2025-12-29 18:19:26 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Apr 27, 2019):

#2426 was a feature request that has been closed and implemented, but you're welcome to open a new bug for the issue (please be sure to complete the bug report template).

@jeremystretch commented on GitHub (Apr 27, 2019): #2426 was a feature request that has been closed and implemented, but you're welcome to open a new bug for the issue (please be sure to complete the bug report template).
adam commented 2025-12-29 18:19:26 +01:00
Author
Owner
Copy Link

@kartiksubbarao commented on GitHub (Apr 27, 2019):

Ok, I've opened #3118

@kartiksubbarao commented on GitHub (Apr 27, 2019): Ok, I've opened #3118
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#2500
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?