starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #16732] [MERGED] SSO: custom name for identity providers #14896

New Issue
Closed
opened 2025-12-29 23:27:21 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:27:21 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16732
Author: @tobast
Created: 6/26/2024
Status: ✅ Merged
Merged: 7/10/2024
Merged by: @arthanson

Base: develop ← Head: tbastian/custom_idp_name

📝 Commits (2)

  • 99b09e6 SSO: allow overriding AUTH_BACKEND_ATTRS
  • 23beda5 SSO: allow specifying custom icon URL

📊 Changes

4 files changed (+37 additions, -4 deletions)

View changed files

📝 docs/administration/authentication/overview.md (+19 -0)
📝 netbox/account/views.py (+11 -1)
📝 netbox/netbox/authentication/__init__.py (+5 -2)
📝 netbox/templates/login.html (+2 -1)

📄 Description

Fixes: #15375 -- allows a user to customize the display aspect of social login providers (SSO and such).

This PR is separated into two commits on purpose.

The first one fixes #15375 and adds relevant documentation. Users may specify in their configuration SOCIAL_AUTH_BACKEND_ATTRS, which override the display name of a social login provider, based on the name attribute of the REMOTE_AUTH_BACKEND class.

The second one allows to use an arbitrary URL as the identity provider's image. Using mdi icons works well for eg. Github social auth, but does not allow for corporate branding of an internal SSO (which is often expected by users).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16732 **Author:** [@tobast](https://github.com/tobast) **Created:** 6/26/2024 **Status:** ✅ Merged **Merged:** 7/10/2024 **Merged by:** [@arthanson](https://github.com/arthanson) **Base:** `develop` ← **Head:** `tbastian/custom_idp_name` --- ### 📝 Commits (2) - [`99b09e6`](https://github.com/netbox-community/netbox/commit/99b09e66a8bc0e7d7ce29695038ee55cd7f1a6ae) SSO: allow overriding AUTH_BACKEND_ATTRS - [`23beda5`](https://github.com/netbox-community/netbox/commit/23beda54d9f0b7c54b2ba6c68581a21c3bd85258) SSO: allow specifying custom icon URL ### 📊 Changes **4 files changed** (+37 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `docs/administration/authentication/overview.md` (+19 -0) 📝 `netbox/account/views.py` (+11 -1) 📝 `netbox/netbox/authentication/__init__.py` (+5 -2) 📝 `netbox/templates/login.html` (+2 -1) </details> ### 📄 Description Fixes: #15375 -- allows a user to customize the display aspect of social login providers (SSO and such). This PR is separated into two commits on purpose. The first one fixes #15375 and adds relevant documentation. Users may specify in their configuration `SOCIAL_AUTH_BACKEND_ATTRS`, which override the display name of a social login provider, based on the `name` attribute of the `REMOTE_AUTH_BACKEND` class. The second one allows to use an arbitrary URL as the identity provider's image. Using mdi icons works well for eg. Github social auth, but does not allow for corporate branding of an internal SSO (which is often expected by users). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:27:21 +01:00
adam closed this issue 2025-12-29 23:27:22 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14896
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?