starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18536] [CLOSED] 18535 skip incompatible plugins #15375

New Issue
Closed
opened 2025-12-30 00:21:33 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:21:33 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18536
Author: @bctiemann
Created: 1/30/2025
Status: ❌ Closed

Base: feature ← Head: 18535-skip-incompatible-plugins

📝 Commits (10+)

📊 Changes

82 files changed (+71108 additions, -64992 deletions)

View changed files

📝 .github/ISSUE_TEMPLATE/01-feature_request.yaml (+2 -14)
📝 .github/ISSUE_TEMPLATE/02-bug_report.yaml (+2 -14)
📝 .github/ISSUE_TEMPLATE/03-documentation_change.yaml (+1 -0)
📝 .github/ISSUE_TEMPLATE/04-translation.yaml (+1 -0)
📝 .github/ISSUE_TEMPLATE/05-housekeeping.yaml (+1 -0)
📝 .github/ISSUE_TEMPLATE/06-deprecation.yaml (+1 -0)
📝 .github/ISSUE_TEMPLATE/config.yml (+1 -1)
📝 .github/workflows/ci.yml (+4 -0)
📝 .github/workflows/close-stale-issues.yml (+1 -1)
📝 CONTRIBUTING.md (+1 -1)
📝 README.md (+3 -3)
📝 base_requirements.txt (+2 -3)
📝 docs/configuration/required-parameters.md (+2 -2)
📝 docs/development/getting-started.md (+4 -8)
📝 docs/development/git-cheat-sheet.md (+2 -2)
📝 docs/development/index.md (+4 -5)
📝 docs/development/release-checklist.md (+16 -13)
📝 docs/development/translations.md (+2 -2)
📝 docs/features/facilities.md (+1 -1)
📝 docs/installation/1-postgresql.md (+6 -3)

...and 62 more files

📄 Description

Closes: #18535

Changes the behavior of the PluginConfig.validate method so that if a plugin with incompatible min or max version specified, it raises an IncompatiblePluginError which is caught in settings.py and registering the plugin is skipped, allowing NetBox to launch cleanly with the plugin disabled.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18536 **Author:** [@bctiemann](https://github.com/bctiemann) **Created:** 1/30/2025 **Status:** ❌ Closed **Base:** `feature` ← **Head:** `18535-skip-incompatible-plugins` --- ### 📝 Commits (10+) - [`ab0a1f0`](https://github.com/netbox-community/netbox/commit/ab0a1f0bbcbdd43a58167348b15e0f2ea12c3dcb) Merge pull request #18308 from netbox-community/feature - [`b761097`](https://github.com/netbox-community/netbox/commit/b7610971c0a53ac1841131a7fa12d0bc1812ac43) Closes #13366: Update documentation for `main` branch (#18309) - [`9d82a66`](https://github.com/netbox-community/netbox/commit/9d82a668a4a8a2762d8f1f6a9754234a99888313) Release v4.2.0 - [`14cec51`](https://github.com/netbox-community/netbox/commit/14cec518f5fd9e2ac75d6342a476b9250ad8861a) Closes #18311: Update minimum required version of PostgreSQL - [`ed54122`](https://github.com/netbox-community/netbox/commit/ed541220e85ccb1093947d216f3b0e2acd040c20) Update source translation strings - [`9c960c2`](https://github.com/netbox-community/netbox/commit/9c960c2387fcc50004f4694b199a588098f82df0) Fixes #18318: Correct navigation breadcrumbs for module type UI view - [`ef6c89e`](https://github.com/netbox-community/netbox/commit/ef6c89ee5de815e2304e59b6042b7dcc9aea383c) Fixes #18324: Correct filter names for certain related object listings - [`4ae5529`](https://github.com/netbox-community/netbox/commit/4ae552936256f536abe2701a9cec1c9bf565f77c) Fix #18314: Use get to avoid KeyError - [`e518f08`](https://github.com/netbox-community/netbox/commit/e518f086040e3b5bfc14f70cc63064cd3893c750) Fixes: #18316 - Fix PrefixIndex reference to 'site' (#18322) - [`ffac097`](https://github.com/netbox-community/netbox/commit/ffac0974dd31c5824f665aa8077f010581a6cfdf) Update source translation strings ### 📊 Changes **82 files changed** (+71108 additions, -64992 deletions) <details> <summary>View changed files</summary> 📝 `.github/ISSUE_TEMPLATE/01-feature_request.yaml` (+2 -14) 📝 `.github/ISSUE_TEMPLATE/02-bug_report.yaml` (+2 -14) 📝 `.github/ISSUE_TEMPLATE/03-documentation_change.yaml` (+1 -0) 📝 `.github/ISSUE_TEMPLATE/04-translation.yaml` (+1 -0) 📝 `.github/ISSUE_TEMPLATE/05-housekeeping.yaml` (+1 -0) 📝 `.github/ISSUE_TEMPLATE/06-deprecation.yaml` (+1 -0) 📝 `.github/ISSUE_TEMPLATE/config.yml` (+1 -1) 📝 `.github/workflows/ci.yml` (+4 -0) 📝 `.github/workflows/close-stale-issues.yml` (+1 -1) 📝 `CONTRIBUTING.md` (+1 -1) 📝 `README.md` (+3 -3) 📝 `base_requirements.txt` (+2 -3) 📝 `docs/configuration/required-parameters.md` (+2 -2) 📝 `docs/development/getting-started.md` (+4 -8) 📝 `docs/development/git-cheat-sheet.md` (+2 -2) 📝 `docs/development/index.md` (+4 -5) 📝 `docs/development/release-checklist.md` (+16 -13) 📝 `docs/development/translations.md` (+2 -2) 📝 `docs/features/facilities.md` (+1 -1) 📝 `docs/installation/1-postgresql.md` (+6 -3) _...and 62 more files_ </details> ### 📄 Description ### Closes: #18535 Changes the behavior of the `PluginConfig.validate` method so that if a plugin with incompatible min or max version specified, it raises an `IncompatiblePluginError` which is caught in `settings.py` and registering the plugin is skipped, allowing NetBox to launch cleanly with the plugin disabled. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:21:33 +01:00
adam closed this issue 2025-12-30 00:21:34 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15375
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?