starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #15315] [MERGED] Closes #15292: Remove obsolete device_role attribute from Device model #14573

New Issue
Closed
opened 2025-12-29 23:25:16 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:25:16 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/15315
Author: @jeremystretch
Created: 2/29/2024
Status: ✅ Merged
Merged: 3/1/2024
Merged by: @jeremystretch

Base: feature ← Head: 15292-remove-device_role

📝 Commits (1)

  • da4af35 Closes #15292: Remove obsolete device_role attribute from Device model

📊 Changes

6 files changed (+18 additions, -60 deletions)

View changed files

📝 docs/customization/custom-scripts.md (+1 -1)
📝 docs/models/dcim/device.md (+2 -2)
📝 netbox/dcim/api/serializers.py (+14 -18)
📝 netbox/dcim/models/devices.py (+0 -14)
📝 netbox/dcim/tests/test_cablepaths.py (+1 -1)
📝 netbox/dcim/tests/test_models.py (+0 -24)

📄 Description

Fixes: #15292

  • Remove the device_role property (a wrapper for role) from the Device model
  • Remove the device_role field from the REST API serializer

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/15315 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 2/29/2024 **Status:** ✅ Merged **Merged:** 3/1/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `15292-remove-device_role` --- ### 📝 Commits (1) - [`da4af35`](https://github.com/netbox-community/netbox/commit/da4af356b7d43801a63abca429550351b442b838) Closes #15292: Remove obsolete device_role attribute from Device model ### 📊 Changes **6 files changed** (+18 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `docs/customization/custom-scripts.md` (+1 -1) 📝 `docs/models/dcim/device.md` (+2 -2) 📝 `netbox/dcim/api/serializers.py` (+14 -18) 📝 `netbox/dcim/models/devices.py` (+0 -14) 📝 `netbox/dcim/tests/test_cablepaths.py` (+1 -1) 📝 `netbox/dcim/tests/test_models.py` (+0 -24) </details> ### 📄 Description ### Fixes: #15292 - Remove the `device_role` property (a wrapper for `role`) from the Device model - Remove the `device_role` field from the REST API serializer --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:25:16 +01:00
adam closed this issue 2025-12-29 23:25:16 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14573
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?