starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18226] [MERGED] Fixes: #16757 - Use table_htmx.html for assigning ipaddresses #15292

New Issue
Closed
opened 2025-12-30 00:21:06 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:21:06 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18226
Author: @bctiemann
Created: 12/12/2024
Status: ✅ Merged
Merged: 12/17/2024
Merged by: @jeremystretch

Base: develop ← Head: 16757-fix-htmx-targeting-ipaddress-assign

📝 Commits (3)

  • 37c9ed2 Use table_htmx.html for assigning ipaddresses
  • fa8f2ac Add disable_htmx property on ObjectChildrenView to allow IP assignment flow to avoid htmx fragmentary rendering on object save
  • ccfda54 Revert "Add disable_htmx property on ObjectChildrenView to allow IP assignment flow to avoid htmx fragmentary rendering on object save"

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 netbox/templates/ipam/ipaddress_assign.html (+1 -1)

📄 Description

Fixes: #16757

Swaps inc/table_htmx.html for inc/table.html in the ipaddress_assign.html template. This ensures that objects clicked on in that table return a properly targeted HTMX response, whether or not HTMX navigation is turned on.

There are many places where inc/table.html is used, but it appears HTMX targeting is not used in those places. As HTMX is rolled out more pervasively, these will all need to be audited.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18226 **Author:** [@bctiemann](https://github.com/bctiemann) **Created:** 12/12/2024 **Status:** ✅ Merged **Merged:** 12/17/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `16757-fix-htmx-targeting-ipaddress-assign` --- ### 📝 Commits (3) - [`37c9ed2`](https://github.com/netbox-community/netbox/commit/37c9ed2fef1af0aa0123c6400c881350b583dc19) Use table_htmx.html for assigning ipaddresses - [`fa8f2ac`](https://github.com/netbox-community/netbox/commit/fa8f2ac3773780bdf9f2555843dae72ab1f185cc) Add disable_htmx property on ObjectChildrenView to allow IP assignment flow to avoid htmx fragmentary rendering on object save - [`ccfda54`](https://github.com/netbox-community/netbox/commit/ccfda54b50479117da8caf4fe0d095489768927c) Revert "Add disable_htmx property on ObjectChildrenView to allow IP assignment flow to avoid htmx fragmentary rendering on object save" ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/templates/ipam/ipaddress_assign.html` (+1 -1) </details> ### 📄 Description ### Fixes: #16757 Swaps `inc/table_htmx.html` for `inc/table.html` in the `ipaddress_assign.html` template. This ensures that objects clicked on in that table return a properly targeted HTMX response, whether or not HTMX navigation is turned on. There are many places where `inc/table.html` is used, but it appears HTMX targeting is not used in those places. As HTMX is rolled out more pervasively, these will all need to be audited. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:21:06 +01:00
adam closed this issue 2025-12-30 00:21:06 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15292
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?