[PR #15301] [MERGED] Fixes: #13722 - Correct range expansion code when a numeric set is used #14566

New Issue

adam · 2025-12-29T23:25:14+01:00

adam commented

2025-12-29 23:25:14 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/15301
Author: @DanSheps
Created: 2/28/2024
Status: ✅ Merged
Merged: 3/11/2024
Merged by: @jeremystretch

Base: develop ← Head: 13722-fixes-range-expansion

📝 Commits (4)

017a66b Fixes: #13722 - Correct range expansion code when a numeric set is used
221e095 Correct to my own suggestion
665ea40 Clean up logic
ad12984 Simplify range detection

📊 Changes

2 files changed (+36 additions, -20 deletions)

View changed files

📝 netbox/utilities/forms/utils.py (+26 -19)
📝 netbox/utilities/tests/test_forms.py (+10 -1)

📄 Description

Fixes: #13722 - Correct range expansion code when a numeric set is used

Correct range expansion to account for a numeric set ([1,2])
Added test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/15301 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 2/28/2024 **Status:** ✅ Merged **Merged:** 3/11/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `13722-fixes-range-expansion` --- ### 📝 Commits (4) - [`017a66b`](https://github.com/netbox-community/netbox/commit/017a66b5f9835b913f0260979b3cd3e126a0a4b7) Fixes: #13722 - Correct range expansion code when a numeric set is used - [`221e095`](https://github.com/netbox-community/netbox/commit/221e095f1d7e0b8e58b3c5bb52c4e7c62adf8ab2) Correct to my own suggestion - [`665ea40`](https://github.com/netbox-community/netbox/commit/665ea402f68800e82a06eae352ddf31acf1fe45b) Clean up logic - [`ad12984`](https://github.com/netbox-community/netbox/commit/ad1298428fa013d80d9dcc034014509e78e0a2a5) Simplify range detection ### 📊 Changes **2 files changed** (+36 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `netbox/utilities/forms/utils.py` (+26 -19) 📝 `netbox/utilities/tests/test_forms.py` (+10 -1) </details> ### 📄 Description ### Fixes: #13722 - Correct range expansion code when a numeric set is used * Correct range expansion to account for a numeric set ([1,2]) * Added test --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 23:25:14 +01:00

adam closed this issue

2025-12-29 23:25:14 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#14566