[PR #18254] [MERGED] Fixes: #18203 - Validate that scope is selected if scope type is specified #15301

New Issue

adam · 2025-12-30T00:21:09+01:00

adam commented

2025-12-30 00:21:09 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18254
Author: @bctiemann
Created: 12/18/2024
Status: ✅ Merged
Merged: 12/30/2024
Merged by: @jeremystretch

Base: feature ← Head: 18203-scope-type-without-scope

📝 Commits (3)

bf82101 Validate that a scope has been selected if a scope_type is specified, on CachedScopeMixin models
6a4c944 Cleaner logic
a710cec Call super().clean() after validating scope_type/scope

📊 Changes

1 file changed (+12 additions, -0 deletions)

View changed files

📝 netbox/dcim/models/mixins.py (+12 -0)

📄 Description

Fixes: #18203

On models with CachedScopeMixin (Prefix, Cluster, WirelessLAN), ensure that if a ScopeType is specified in the create or edit form, a Scope must also be selected. This prevents a spurious error being raised: 'PrefixForm' has no field named 'scope_id'.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18254 **Author:** [@bctiemann](https://github.com/bctiemann) **Created:** 12/18/2024 **Status:** ✅ Merged **Merged:** 12/30/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `18203-scope-type-without-scope` --- ### 📝 Commits (3) - [`bf82101`](https://github.com/netbox-community/netbox/commit/bf82101e84b61a2c3eae44947c33de26926c756d) Validate that a scope has been selected if a scope_type is specified, on CachedScopeMixin models - [`6a4c944`](https://github.com/netbox-community/netbox/commit/6a4c944e64093c05edd65e5dfa094c1dc3d403dc) Cleaner logic - [`a710cec`](https://github.com/netbox-community/netbox/commit/a710cec061178615a53b5ae4323b8b4463bb975b) Call super().clean() after validating scope_type/scope ### 📊 Changes **1 file changed** (+12 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/models/mixins.py` (+12 -0) </details> ### 📄 Description ### Fixes: #18203 On models with `CachedScopeMixin` (`Prefix`, `Cluster`, `WirelessLAN`), ensure that if a ScopeType is specified in the create or edit form, a Scope must also be selected. This prevents a spurious error being raised: `'PrefixForm' has no field named 'scope_id'.` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:21:09 +01:00

adam closed this issue

2025-12-30 00:21:09 +01:00

Sign in to join this conversation.

Branches Tags

main

21050-device-oob-ip-may-become-orphaned

21102-fix-graphiql-explorer

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#15301