[PR #15155] [MERGED] 15094 Add missing gettext to error strings for internationalization #14533

New Issue

adam · 2025-12-29T23:25:02+01:00

adam commented

2025-12-29 23:25:02 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/15155
Author: @arthanson
Created: 2/14/2024
Status: ✅ Merged
Merged: 2/20/2024
Merged by: @jeremystretch

Base: develop ← Head: 15094-int-error-msg

📝 Commits (5)

4416657 15049 add missing gettext to error strings
3f305d1 15049 add missing gettext to error strings
07ee64e 15094 review change
5aa5b32 15094 review change
dd22ebe Formatting cleanup

📊 Changes

47 files changed (+275 additions, -133 deletions)

View changed files

📝 netbox/circuits/models/circuits.py (+2 -2)
📝 netbox/core/data_backends.py (+1 -1)
📝 netbox/core/forms/model_forms.py (+2 -2)
📝 netbox/core/models/data.py (+2 -2)
📝 netbox/core/models/jobs.py (+5 -1)
📝 netbox/dcim/fields.py (+3 -2)
📝 netbox/dcim/forms/bulk_import.py (+20 -5)
📝 netbox/dcim/models/cables.py (+18 -10)
📝 netbox/dcim/tests/test_api.py (+2 -1)
📝 netbox/extras/api/customfields.py (+2 -1)
📝 netbox/extras/api/serializers.py (+6 -5)
📝 netbox/extras/conditions.py (+12 -6)
📝 netbox/extras/dashboard/utils.py (+2 -1)
📝 netbox/extras/dashboard/widgets.py (+5 -3)
📝 netbox/extras/events.py (+5 -2)
📝 netbox/extras/forms/bulk_import.py (+2 -2)
📝 netbox/extras/management/commands/reindex.py (+2 -1)
📝 netbox/extras/scripts.py (+4 -3)
📝 netbox/ipam/api/views.py (+2 -1)
📝 netbox/ipam/fields.py (+2 -1)

...and 27 more files

📄 Description

Fixes: #15094

Was obviously not able to test each individual error message so another set of eyes to double check the formatting would be appreciated.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/15155 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 2/14/2024 **Status:** ✅ Merged **Merged:** 2/20/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `15094-int-error-msg` --- ### 📝 Commits (5) - [`4416657`](https://github.com/netbox-community/netbox/commit/4416657681c36669d526e30da6d3487876baebbd) 15049 add missing gettext to error strings - [`3f305d1`](https://github.com/netbox-community/netbox/commit/3f305d199d248c3b0a774b5024f451ee817750b9) 15049 add missing gettext to error strings - [`07ee64e`](https://github.com/netbox-community/netbox/commit/07ee64e6bdcc1328b3cf6ca80fe76a099363f8ec) 15094 review change - [`5aa5b32`](https://github.com/netbox-community/netbox/commit/5aa5b325df74b78f2cc22622d5e99a4666e1a4ed) 15094 review change - [`dd22ebe`](https://github.com/netbox-community/netbox/commit/dd22ebe5bcf9143136216d4dc32954a6088a36e2) Formatting cleanup ### 📊 Changes **47 files changed** (+275 additions, -133 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/models/circuits.py` (+2 -2) 📝 `netbox/core/data_backends.py` (+1 -1) 📝 `netbox/core/forms/model_forms.py` (+2 -2) 📝 `netbox/core/models/data.py` (+2 -2) 📝 `netbox/core/models/jobs.py` (+5 -1) 📝 `netbox/dcim/fields.py` (+3 -2) 📝 `netbox/dcim/forms/bulk_import.py` (+20 -5) 📝 `netbox/dcim/models/cables.py` (+18 -10) 📝 `netbox/dcim/tests/test_api.py` (+2 -1) 📝 `netbox/extras/api/customfields.py` (+2 -1) 📝 `netbox/extras/api/serializers.py` (+6 -5) 📝 `netbox/extras/conditions.py` (+12 -6) 📝 `netbox/extras/dashboard/utils.py` (+2 -1) 📝 `netbox/extras/dashboard/widgets.py` (+5 -3) 📝 `netbox/extras/events.py` (+5 -2) 📝 `netbox/extras/forms/bulk_import.py` (+2 -2) 📝 `netbox/extras/management/commands/reindex.py` (+2 -1) 📝 `netbox/extras/scripts.py` (+4 -3) 📝 `netbox/ipam/api/views.py` (+2 -1) 📝 `netbox/ipam/fields.py` (+2 -1) _...and 27 more files_ </details> ### 📄 Description ### Fixes: #15094 Was obviously not able to test each individual error message so another set of eyes to double check the formatting would be appreciated. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 23:25:02 +01:00

adam closed this issue

2025-12-29 23:25:02 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#14533