starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17629] [MERGED] 16547 Add distance to Circuit #15155

New Issue
Closed
opened 2025-12-30 00:20:18 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:20:18 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17629
Author: @arthanson
Created: 9/27/2024
Status: ✅ Merged
Merged: 10/10/2024
Merged by: @jeremystretch

Base: feature ← Head: 16547-circuit-distance

📝 Commits (9)

📊 Changes

38 files changed (+290 additions, -150 deletions)

View changed files

📝 docs/models/circuits/circuit.md (+6 -0)
📝 netbox/circuits/api/serializers_/circuits.py (+3 -1)
📝 netbox/circuits/filtersets.py (+1 -1)
📝 netbox/circuits/forms/bulk_edit.py (+13 -0)
📝 netbox/circuits/forms/bulk_import.py (+8 -1)
📝 netbox/circuits/forms/filtersets.py (+12 -1)
📝 netbox/circuits/forms/model_forms.py (+13 -3)
➕ netbox/circuits/migrations/0045_circuit_distance.py (+28 -0)
📝 netbox/circuits/models/circuits.py (+2 -1)
📝 netbox/circuits/tables/circuits.py (+1 -0)
📝 netbox/circuits/tests/test_filtersets.py (+12 -3)
📝 netbox/dcim/api/serializers_/devicetypes.py (+1 -0)
📝 netbox/dcim/api/serializers_/racks.py (+1 -0)
📝 netbox/dcim/choices.py (+0 -18)
📝 netbox/dcim/forms/bulk_edit.py (+1 -0)
📝 netbox/dcim/forms/bulk_import.py (+1 -0)
📝 netbox/dcim/forms/filtersets.py (+1 -0)
📝 netbox/dcim/models/devices.py (+2 -1)
📝 netbox/dcim/models/mixins.py (+0 -44)
📝 netbox/dcim/models/racks.py (+1 -1)

...and 18 more files

📄 Description

Fixes: #16547

This has more changes as refactored WirelessLinkDistanceChoices to DistanceChoices as made it as a mixin as it is used in 3 models now so should make it DRY.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17629 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 9/27/2024 **Status:** ✅ Merged **Merged:** 10/10/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `16547-circuit-distance` --- ### 📝 Commits (9) - [`79e5108`](https://github.com/netbox-community/netbox/commit/79e51084bf565cb0ee89a4c09eb4dd6cf6c61260) 16547 Add distance to Circuit - [`d5f2bab`](https://github.com/netbox-community/netbox/commit/d5f2bab132d62f59bab4eb6028b7a11a17edfc8b) 16547 fix test cases - [`db83a67`](https://github.com/netbox-community/netbox/commit/db83a676fd860798d1ab8722214e1966726fa198) 16547 fix test cases - [`de87763`](https://github.com/netbox-community/netbox/commit/de87763572b64b8eba72c5de68c27c451dbd5a57) 16547 add distance to API, forms, tables - [`2bfc77b`](https://github.com/netbox-community/netbox/commit/2bfc77bba0de6a63121e4d74ee05153951288c5f) 16547 fixes - [`45ad5c6`](https://github.com/netbox-community/netbox/commit/45ad5c6d91eb51b3cc2aa0d421bb6da0912b3841) 16547 fixes - [`9ace92f`](https://github.com/netbox-community/netbox/commit/9ace92f42d2e0a5031431c9cb52077fd2f275f93) 16547 review changes - [`2827374`](https://github.com/netbox-community/netbox/commit/2827374346a74854a065157fc3771ac2da5fafe7) 16547 review changes - [`ecdb383`](https://github.com/netbox-community/netbox/commit/ecdb3834ce2bc8abc9ad7d27e50e1789b9a782a6) Clean up DistanceColumn ### 📊 Changes **38 files changed** (+290 additions, -150 deletions) <details> <summary>View changed files</summary> 📝 `docs/models/circuits/circuit.md` (+6 -0) 📝 `netbox/circuits/api/serializers_/circuits.py` (+3 -1) 📝 `netbox/circuits/filtersets.py` (+1 -1) 📝 `netbox/circuits/forms/bulk_edit.py` (+13 -0) 📝 `netbox/circuits/forms/bulk_import.py` (+8 -1) 📝 `netbox/circuits/forms/filtersets.py` (+12 -1) 📝 `netbox/circuits/forms/model_forms.py` (+13 -3) ➕ `netbox/circuits/migrations/0045_circuit_distance.py` (+28 -0) 📝 `netbox/circuits/models/circuits.py` (+2 -1) 📝 `netbox/circuits/tables/circuits.py` (+1 -0) 📝 `netbox/circuits/tests/test_filtersets.py` (+12 -3) 📝 `netbox/dcim/api/serializers_/devicetypes.py` (+1 -0) 📝 `netbox/dcim/api/serializers_/racks.py` (+1 -0) 📝 `netbox/dcim/choices.py` (+0 -18) 📝 `netbox/dcim/forms/bulk_edit.py` (+1 -0) 📝 `netbox/dcim/forms/bulk_import.py` (+1 -0) 📝 `netbox/dcim/forms/filtersets.py` (+1 -0) 📝 `netbox/dcim/models/devices.py` (+2 -1) 📝 `netbox/dcim/models/mixins.py` (+0 -44) 📝 `netbox/dcim/models/racks.py` (+1 -1) _...and 18 more files_ </details> ### 📄 Description ### Fixes: #16547 This has more changes as refactored WirelessLinkDistanceChoices to DistanceChoices as made it as a mixin as it is used in 3 models now so should make it DRY. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:20:18 +01:00
adam closed this issue 2025-12-30 00:20:18 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15155
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?