starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #14632] [MERGED] Closes #14631: Ensure description filters are available on all relevant models #14432

New Issue
Closed
opened 2025-12-29 23:24:27 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:24:27 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/14632
Author: @jeremystretch
Created: 12/28/2023
Status: ✅ Merged
Merged: 12/28/2023
Merged by: @jeremystretch

Base: develop ← Head: 14631-description-filters

📝 Commits (2)

  • f2640f9 Closes #14631: Ensure description filters are available on all relevant models
  • 8691842 Closes #14629: Add filter tests for all q and description filters

📊 Changes

17 files changed (+1510 additions, -300 deletions)

View changed files

📝 netbox/circuits/filtersets.py (+3 -1)
📝 netbox/circuits/tests/test_filtersets.py (+30 -2)
📝 netbox/core/filtersets.py (+1 -1)
📝 netbox/core/tests/test_filtersets.py (+16 -2)
📝 netbox/dcim/filtersets.py (+46 -24)
📝 netbox/dcim/tests/test_filtersets.py (+729 -155)
📝 netbox/extras/filtersets.py (+1 -1)
📝 netbox/extras/tests/test_filtersets.py (+88 -19)
📝 netbox/ipam/filtersets.py (+6 -3)
📝 netbox/ipam/tests/test_filtersets.py (+344 -55)
📝 netbox/netbox/filtersets.py (+2 -1)
📝 netbox/tenancy/filtersets.py (+2 -1)
📝 netbox/tenancy/tests/test_filtersets.py (+67 -13)
📝 netbox/users/tests/test_filtersets.py (+16 -0)
📝 netbox/virtualization/filtersets.py (+4 -2)
📝 netbox/virtualization/tests/test_filtersets.py (+133 -17)
📝 netbox/wireless/tests/test_filtersets.py (+22 -3)

📄 Description

Fixes: #14631

  • Add a description filter to any applicable FilterSets which do not already have one
  • Ensure that all q filters match against the description field if one exists on the associated model
  • Extend FilterSet tests to test all q and description filters (closes #14629)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/14632 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 12/28/2023 **Status:** ✅ Merged **Merged:** 12/28/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `14631-description-filters` --- ### 📝 Commits (2) - [`f2640f9`](https://github.com/netbox-community/netbox/commit/f2640f9bae1ccd48da7ede5054f675c0066f03bd) Closes #14631: Ensure description filters are available on all relevant models - [`8691842`](https://github.com/netbox-community/netbox/commit/86918422c39fdfa47150b48b9a0c2371012ea99e) Closes #14629: Add filter tests for all q and description filters ### 📊 Changes **17 files changed** (+1510 additions, -300 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/filtersets.py` (+3 -1) 📝 `netbox/circuits/tests/test_filtersets.py` (+30 -2) 📝 `netbox/core/filtersets.py` (+1 -1) 📝 `netbox/core/tests/test_filtersets.py` (+16 -2) 📝 `netbox/dcim/filtersets.py` (+46 -24) 📝 `netbox/dcim/tests/test_filtersets.py` (+729 -155) 📝 `netbox/extras/filtersets.py` (+1 -1) 📝 `netbox/extras/tests/test_filtersets.py` (+88 -19) 📝 `netbox/ipam/filtersets.py` (+6 -3) 📝 `netbox/ipam/tests/test_filtersets.py` (+344 -55) 📝 `netbox/netbox/filtersets.py` (+2 -1) 📝 `netbox/tenancy/filtersets.py` (+2 -1) 📝 `netbox/tenancy/tests/test_filtersets.py` (+67 -13) 📝 `netbox/users/tests/test_filtersets.py` (+16 -0) 📝 `netbox/virtualization/filtersets.py` (+4 -2) 📝 `netbox/virtualization/tests/test_filtersets.py` (+133 -17) 📝 `netbox/wireless/tests/test_filtersets.py` (+22 -3) </details> ### 📄 Description ### Fixes: #14631 - Add a `description` filter to any applicable FilterSets which do not already have one - Ensure that all `q` filters match against the `description` field if one exists on the associated model - Extend FilterSet tests to test all `q` and `description` filters (closes #14629) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:24:27 +01:00
adam closed this issue 2025-12-29 23:24:27 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14432
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?