starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #15642] [MERGED] Fixes #15637: Fix rendering of links from within embedded tables w/HTMX enabled #14631

New Issue
Closed
opened 2025-12-29 23:25:39 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:25:39 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/15642
Author: @jeremystretch
Created: 4/5/2024
Status: ✅ Merged
Merged: 4/5/2024
Merged by: @jeremystretch

Base: feature ← Head: 15637-htmx-embedded-tables

📝 Commits (4)

  • a9e94bf Add htmx_table to all
  • 9a9d47f Fix dropdown menu clipping
  • aff72b1 Fix loading links from within embedded tables
  • ef28538 Fix rendering of object deletion warning

📊 Changes

6 files changed (+6 additions, -6 deletions)

View changed files

📝 netbox/netbox/views/generic/object_views.py (+1 -1)
📝 netbox/templates/generic/object_delete.html (+1 -1)
📝 netbox/templates/inc/table_htmx.html (+1 -2)
📝 netbox/utilities/htmx.py (+1 -1)
📝 netbox/utilities/templates/builtins/htmx_table.html (+1 -1)
📝 netbox/utilities/templatetags/builtins/tags.py (+1 -0)

📄 Description

Fixes: #15637

  • Fix dropdown menu clipping
  • Fix loading links from within embedded tables
  • Fix rendering of object deletion warning

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/15642 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 4/5/2024 **Status:** ✅ Merged **Merged:** 4/5/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `15637-htmx-embedded-tables` --- ### 📝 Commits (4) - [`a9e94bf`](https://github.com/netbox-community/netbox/commit/a9e94bf2b1b674a62a4c1f1904664d3ff0ffcf8c) Add htmx_table to __all__ - [`9a9d47f`](https://github.com/netbox-community/netbox/commit/9a9d47fc452fe87cfddf7732c54804eb9717897e) Fix dropdown menu clipping - [`aff72b1`](https://github.com/netbox-community/netbox/commit/aff72b132c3d26c635573bb6a1c60e13ff2cd169) Fix loading links from within embedded tables - [`ef28538`](https://github.com/netbox-community/netbox/commit/ef2853813ce5d4ff5805891ca27d58897c4be999) Fix rendering of object deletion warning ### 📊 Changes **6 files changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/views/generic/object_views.py` (+1 -1) 📝 `netbox/templates/generic/object_delete.html` (+1 -1) 📝 `netbox/templates/inc/table_htmx.html` (+1 -2) 📝 `netbox/utilities/htmx.py` (+1 -1) 📝 `netbox/utilities/templates/builtins/htmx_table.html` (+1 -1) 📝 `netbox/utilities/templatetags/builtins/tags.py` (+1 -0) </details> ### 📄 Description ### Fixes: #15637 - Fix dropdown menu clipping - Fix loading links from within embedded tables - Fix rendering of object deletion warning --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:25:39 +01:00
adam closed this issue 2025-12-29 23:25:39 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14631
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?