starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #14571] [MERGED] Fixes #14550: Fix changing event rule action type from webhook to script #14415

New Issue
Closed
opened 2025-12-29 23:24:21 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:24:21 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/14571
Author: @jeremystretch
Created: 12/20/2023
Status: ✅ Merged
Merged: 12/22/2023
Merged by: @jeremystretch

Base: feature ← Head: 14550-eventrule-fix

📝 Commits (2)

  • 78c8982 Fixes #14550: Fix changing event rule action type from webhook to script
  • 4d51ad0 Remove action_parameters from form; set on instance under save()

📊 Changes

1 file changed (+17 additions, -10 deletions)

View changed files

📝 netbox/extras/forms/model_forms.py (+17 -10)

📄 Description

Fixes: #14550

  • Remove the action_parameters field from EventRuleForm (set it on the instance under save())
  • Only initialize existing webhook/script selection if set on the instance

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/14571 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 12/20/2023 **Status:** ✅ Merged **Merged:** 12/22/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `14550-eventrule-fix` --- ### 📝 Commits (2) - [`78c8982`](https://github.com/netbox-community/netbox/commit/78c89829bfebc3ae8f14b8f3f6e6b9396d948c8e) Fixes #14550: Fix changing event rule action type from webhook to script - [`4d51ad0`](https://github.com/netbox-community/netbox/commit/4d51ad0db51b4e3eef1b0fbbff747263c1ee06e3) Remove action_parameters from form; set on instance under save() ### 📊 Changes **1 file changed** (+17 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/forms/model_forms.py` (+17 -10) </details> ### 📄 Description ### Fixes: #14550 - Remove the `action_parameters` field from EventRuleForm (set it on the instance under `save()`) - Only initialize existing webhook/script selection if set on the instance --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:24:21 +01:00
adam closed this issue 2025-12-29 23:24:21 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14415
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?