starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #15207] [MERGED] 15192 fix config revision if no revisions #14550

New Issue
Closed
opened 2025-12-29 23:25:08 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:25:08 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/15207
Author: @arthanson
Created: 2/20/2024
Status: ✅ Merged
Merged: 2/20/2024
Merged by: @jeremystretch

Base: develop ← Head: 15192-fix-config-revision

📝 Commits (1)

  • 9692383 15192 fix config revision if no revisions

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 netbox/core/models/config.py (+1 -1)
📝 netbox/core/views.py (+1 -1)

📄 Description

Fixes: #15192

Fixes two related cases when there are no current config revisions:

  1. If there are no config revisions and you go to http://localhost:8000/core/config/ it will error - that fix is in views.py to return the get_config().defaults.
  2. If you are viewing the now working current config page and choose to edit you will get another error on the edit form for 'NoneType' is not iterable. That is the fix in config.py

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/15207 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 2/20/2024 **Status:** ✅ Merged **Merged:** 2/20/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `15192-fix-config-revision` --- ### 📝 Commits (1) - [`9692383`](https://github.com/netbox-community/netbox/commit/969238348d38c40218e3b582d88741457513eeda) 15192 fix config revision if no revisions ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/core/models/config.py` (+1 -1) 📝 `netbox/core/views.py` (+1 -1) </details> ### 📄 Description ### Fixes: #15192 Fixes two related cases when there are no current config revisions: 1. If there are no config revisions and you go to http://localhost:8000/core/config/ it will error - that fix is in views.py to return the get_config().defaults. 2. If you are viewing the now working current config page and choose to edit you will get another error on the edit form for 'NoneType' is not iterable. That is the fix in config.py --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:25:08 +01:00
adam closed this issue 2025-12-29 23:25:08 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14550
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?