starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #14061] [CLOSED] Closes #13550: Refactor view action mappings #14308

New Issue
Closed
opened 2025-12-29 23:23:43 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:23:43 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/14061
Author: @jeremystretch
Created: 10/17/2023
Status: ❌ Closed

Base: feature ← Head: 13550-view-actions

📝 Commits (10+)

📊 Changes

30 files changed (+350 additions, -132 deletions)

View changed files

📝 .github/ISSUE_TEMPLATE/bug_report.yaml (+1 -1)
📝 .github/ISSUE_TEMPLATE/feature_request.yaml (+1 -1)
📝 base_requirements.txt (+2 -1)
📝 docs/release-notes/version-3.6.md (+15 -1)
📝 netbox/core/views.py (+7 -2)
📝 netbox/dcim/api/views.py (+6 -6)
📝 netbox/dcim/filtersets.py (+17 -0)
📝 netbox/dcim/forms/filtersets.py (+8 -1)
📝 netbox/dcim/tests/test_filtersets.py (+10 -0)
📝 netbox/dcim/views.py (+82 -48)
📝 netbox/extras/views.py (+50 -14)
📝 netbox/ipam/forms/filtersets.py (+5 -1)
📝 netbox/netbox/api/viewsets/__init__.py (+21 -0)
📝 netbox/netbox/constants.py (+11 -0)
📝 netbox/netbox/settings.py (+1 -1)
📝 netbox/netbox/views/generic/mixins.py (+32 -10)
📝 netbox/project-static/dist/netbox.js (+1 -1)
📝 netbox/project-static/dist/netbox.js.map (+1 -1)
📝 netbox/project-static/src/clipboard.ts (+1 -1)
📝 netbox/templates/account/token.html (+0 -5)

...and 10 more files

📄 Description

Closes: #13550

  • Delete perm_actions map from ActionsMixin
  • Convert actions from a tuple to a dictionary mapping
  • Normalize permissions for all actions (every action should require at least one permission)
  • Ensure backward compatibility for plugins

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/14061 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 10/17/2023 **Status:** ❌ Closed **Base:** `feature` ← **Head:** `13550-view-actions` --- ### 📝 Commits (10+) - [`06ed7ac`](https://github.com/netbox-community/netbox/commit/06ed7ac8a5b827c137f25627377200d738eeffe5) Fixes: #14023 - Fixes bulk disconnecting with multiple components attached to the same cable (#14029) - [`14447be`](https://github.com/netbox-community/netbox/commit/14447befb9dd2479ef265ef1a52b9430ffa10ed5) Changelog for #12872, #14013, #14023, #14026 - [`18a813a`](https://github.com/netbox-community/netbox/commit/18a813aa39760636d80ad486a237bf2ec35713ad) 13972 allow filtering of cables if have terminations (#13949) - [`c671ac2`](https://github.com/netbox-community/netbox/commit/c671ac2f28daad8a4761929b86a7d91e56ca3da1) Add dns_name filter on the IP Address page (#14046) - [`a24864b`](https://github.com/netbox-community/netbox/commit/a24864bc6dffc070bfcaeb43158c42dbccefa57f) 14042 mptt cache count (#14048) - [`d77d45e`](https://github.com/netbox-community/netbox/commit/d77d45e795e8341ea95fbb1897daee10f170e429) 12336 make region API calls atomic (#13942) - [`7983c25`](https://github.com/netbox-community/netbox/commit/7983c2590e74b36682c4b76e8a543c709fad0891) 14025 fix script name checking (#14030) - [`51ef4fb`](https://github.com/netbox-community/netbox/commit/51ef4fb920acd689755af6ea9f7765b341ebfcec) Closes #13962: Add a copy-to-clipboard button to the key field of the API token creation form - [`ab9de43`](https://github.com/netbox-community/netbox/commit/ab9de4344785f39a34dfd79ecc1721f22ee69e74) Changelog for #12336, #13957, #13962, #13972, #14025, #14042 - [`3fd8e48`](https://github.com/netbox-community/netbox/commit/3fd8e48fac47d22e3202c101921d6c57cddd0428) Release v3.6.4 ### 📊 Changes **30 files changed** (+350 additions, -132 deletions) <details> <summary>View changed files</summary> 📝 `.github/ISSUE_TEMPLATE/bug_report.yaml` (+1 -1) 📝 `.github/ISSUE_TEMPLATE/feature_request.yaml` (+1 -1) 📝 `base_requirements.txt` (+2 -1) 📝 `docs/release-notes/version-3.6.md` (+15 -1) 📝 `netbox/core/views.py` (+7 -2) 📝 `netbox/dcim/api/views.py` (+6 -6) 📝 `netbox/dcim/filtersets.py` (+17 -0) 📝 `netbox/dcim/forms/filtersets.py` (+8 -1) 📝 `netbox/dcim/tests/test_filtersets.py` (+10 -0) 📝 `netbox/dcim/views.py` (+82 -48) 📝 `netbox/extras/views.py` (+50 -14) 📝 `netbox/ipam/forms/filtersets.py` (+5 -1) 📝 `netbox/netbox/api/viewsets/__init__.py` (+21 -0) 📝 `netbox/netbox/constants.py` (+11 -0) 📝 `netbox/netbox/settings.py` (+1 -1) 📝 `netbox/netbox/views/generic/mixins.py` (+32 -10) 📝 `netbox/project-static/dist/netbox.js` (+1 -1) 📝 `netbox/project-static/dist/netbox.js.map` (+1 -1) 📝 `netbox/project-static/src/clipboard.ts` (+1 -1) 📝 `netbox/templates/account/token.html` (+0 -5) _...and 10 more files_ </details> ### 📄 Description ### Closes: #13550 - Delete `perm_actions` map from ActionsMixin - Convert `actions` from a tuple to a dictionary mapping - Normalize permissions for all actions (every action should require at least one permission) - Ensure backward compatibility for plugins --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:23:43 +01:00
adam closed this issue 2025-12-29 23:23:43 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14308
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?