starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #2226] [CLOSED] Changes to the inheritance of forms to support bulk importing #12336

New Issue
Closed
opened 2025-12-29 22:20:57 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:20:57 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/2226
Author: @sublimestate
Created: 7/9/2018
Status: ❌ Closed

Base: develop ← Head: develop

📝 Commits (1)

  • a797dee Changes to inheritance of forms to custom field forms

📊 Changes

5 files changed (+14 additions, -14 deletions)

View changed files

📝 netbox/circuits/forms.py (+2 -2)
📝 netbox/dcim/forms.py (+4 -4)
📝 netbox/ipam/forms.py (+5 -5)
📝 netbox/tenancy/forms.py (+1 -1)
📝 netbox/virtualization/forms.py (+2 -2)

📄 Description

Fixes: #568 Bulk import custom fields

These changes affect the CSV form classes. Every CSV form class that is related to a model that supports custom fields will inherit from CustomFieldForm instead of forms.ModelForm.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/2226 **Author:** [@sublimestate](https://github.com/sublimestate) **Created:** 7/9/2018 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (1) - [`a797dee`](https://github.com/netbox-community/netbox/commit/a797dee93e738b8ef92830e52a26b3d3a3c811b5) Changes to inheritance of forms to custom field forms ### 📊 Changes **5 files changed** (+14 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/forms.py` (+2 -2) 📝 `netbox/dcim/forms.py` (+4 -4) 📝 `netbox/ipam/forms.py` (+5 -5) 📝 `netbox/tenancy/forms.py` (+1 -1) 📝 `netbox/virtualization/forms.py` (+2 -2) </details> ### 📄 Description <!-- Thank you for your interest in contributing to NetBox! Please note that our contribution policy requires that a feature request or bug report be opened for approval prior to filing a pull request. This helps avoid wasting time and effort on something that we might not be able to accept. Please indicate the relevant feature request or bug report below. --> ### Fixes: #568 Bulk import custom fields <!-- Please include a summary of the proposed changes below. --> These changes affect the CSV form classes. Every CSV form class that is related to a model that supports custom fields will inherit from CustomFieldForm instead of forms.ModelForm. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:20:57 +01:00
adam closed this issue 2025-12-29 22:20:58 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12336
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?