[PR #13946] [MERGED] 12328 update GFK object in clean #14286

New Issue

adam · 2025-12-29T23:23:37+01:00

adam commented

2025-12-29 23:23:37 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/13946
Author: @arthanson
Created: 10/2/2023
Status: ✅ Merged
Merged: 10/3/2023
Merged by: @jeremystretch

Base: develop ← Head: 12328-update-gfk-field

📝 Commits (2)

0af975e 12328 update GFK object in clean
1767045 Add missing import statement

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 netbox/netbox/models/__init__.py (+7 -1)

📄 Description

Fixes: #12328

Potentially a bug in DRF, for the GFK field the _id and _type are set correctly but the content_object isn't set jut on return for a creation on REST API calls. We are already going through all the GFK fields in the clean method so this just adds the actual setting of the content_object field. A very slight performance hit changing from checking existence to actually getting the object. Little bit of a hack to work-around the issue, but I can't think of any side-effects this should have.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/13946 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 10/2/2023 **Status:** ✅ Merged **Merged:** 10/3/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `12328-update-gfk-field` --- ### 📝 Commits (2) - [`0af975e`](https://github.com/netbox-community/netbox/commit/0af975e8561f57408644c4e447075b102f7c908c) 12328 update GFK object in clean - [`1767045`](https://github.com/netbox-community/netbox/commit/1767045b4645258d3ac27f1603f144134c6f4331) Add missing import statement ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/models/__init__.py` (+7 -1) </details> ### 📄 Description ### Fixes: #12328 Potentially a bug in DRF, for the GFK field the _id and _type are set correctly but the content_object isn't set jut on return for a creation on REST API calls. We are already going through all the GFK fields in the clean method so this just adds the actual setting of the content_object field. A very slight performance hit changing from checking existence to actually getting the object. Little bit of a hack to work-around the issue, but I can't think of any side-effects this should have. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 23:23:37 +01:00

adam closed this issue

2025-12-29 23:23:37 +01:00

Sign in to join this conversation.

Branches Tags

main

21102-fix-graphiql-explorer

update-changelog-comments-docs

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#14286