starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #2190] [CLOSED] Add napalm_optional_args field to platform model #12328

New Issue
Closed
opened 2025-12-29 22:20:54 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:20:54 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/2190
Author: @orgito
Created: 6/22/2018
Status: ❌ Closed

Base: develop ← Head: issues/2029

📝 Commits (1)

  • d7491e5 Add napalm_optional_args field to platform model

📊 Changes

4 files changed (+46 additions, -3 deletions)

View changed files

📝 netbox/dcim/api/views.py (+18 -1)
📝 netbox/dcim/forms.py (+1 -1)
➕ netbox/dcim/migrations/0056_platform_napalm_optional_args.py (+20 -0)
📝 netbox/dcim/models.py (+7 -1)

📄 Description

Fixes: #2029

Adding napalm_optional_args as suggested by @jeremystretch to the platform model allowing the user to pass extra arguments directly to the napalm driver.

Instead of a JSON string, the field will accept a comma-separated list of key=value pairs that will be parsed in a dictionary and passed to the napalm driver.

That format is simpler for users to understand and is compatible with the format of the napalm cli tool --optional_args argument.

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/2190 **Author:** [@orgito](https://github.com/orgito) **Created:** 6/22/2018 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `issues/2029` --- ### 📝 Commits (1) - [`d7491e5`](https://github.com/netbox-community/netbox/commit/d7491e58be1810338ae25a331cb761beda4398a0) Add napalm_optional_args field to platform model ### 📊 Changes **4 files changed** (+46 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/api/views.py` (+18 -1) 📝 `netbox/dcim/forms.py` (+1 -1) ➕ `netbox/dcim/migrations/0056_platform_napalm_optional_args.py` (+20 -0) 📝 `netbox/dcim/models.py` (+7 -1) </details> ### 📄 Description ### Fixes: #2029 Adding `napalm_optional_args` as suggested by @jeremystretch to the platform model allowing the user to pass extra arguments directly to the napalm driver. Instead of a JSON string, the field will accept a comma-separated list of key=value pairs that will be parsed in a dictionary and passed to the napalm driver. That format is simpler for users to understand and is compatible with the format of the napalm cli tool `--optional_args` argument. ![image](https://user-images.githubusercontent.com/4852822/41798003-7ba95f38-7642-11e8-8858-6dda8117b9ed.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:20:54 +01:00
adam closed this issue 2025-12-29 22:20:54 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12328
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?