[PR #13388] [MERGED] Adds generic object children template #14178

Closed
opened 2025-12-29 23:23:01 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/13388
Author: @abhi1693
Created: 8/4/2023
Status: Merged
Merged: 8/9/2023
Merged by: @jeremystretch

Base: developHead: feat/12110-generic-tab-view


📝 Commits (10+)

  • ef9cafe adds generic tab view template #12110
  • fa09a47 Merge branch 'develop' into feat/12110-generic-tab-view
  • d790c79 Rename view_tab.html and move to generic/
  • a31ea23 Fix console ports template
  • 4c2a440 Move bulk operations view resolution to template
  • 2af2ccc Avoid setting default template_name on ObjectChildrenView
  • 9652210 Move base_template and table_config context vars to base context
  • 4633cc5 Merge pull request #13402 from netbox-community/13388-optimizations
  • 97ff51c removed bulk_delete_control from templates
  • 89fe8e2 refactored bulk_controls view

📊 Changes

32 files changed (+331 additions, -1003 deletions)

View changed files

📝 netbox/dcim/views.py (+13 -0)
📝 netbox/ipam/views.py (+4 -6)
📝 netbox/netbox/views/generic/object_views.py (+3 -0)
netbox/templates/dcim/device/components_base.html (+15 -0)
📝 netbox/templates/dcim/device/consoleports.html (+21 -51)
📝 netbox/templates/dcim/device/consoleserverports.html (+21 -51)
📝 netbox/templates/dcim/device/devicebays.html (+10 -47)
📝 netbox/templates/dcim/device/frontports.html (+21 -51)
📝 netbox/templates/dcim/device/interfaces.html (+22 -61)
📝 netbox/templates/dcim/device/inventory.html (+10 -47)
📝 netbox/templates/dcim/device/modulebays.html (+10 -43)
📝 netbox/templates/dcim/device/poweroutlets.html (+21 -51)
📝 netbox/templates/dcim/device/powerports.html (+21 -51)
📝 netbox/templates/dcim/device/rearports.html (+21 -51)
📝 netbox/templates/dcim/rack/non_racked_devices.html (+2 -41)
📝 netbox/templates/dcim/rack/reservations.html (+9 -40)
netbox/templates/generic/object_children.html (+57 -0)
📝 netbox/templates/ipam/aggregate/prefixes.html (+2 -37)
netbox/templates/ipam/asnrange/asns.html (+0 -36)
netbox/templates/ipam/ipaddress/ip_addresses.html (+0 -19)

...and 12 more files

📄 Description

Fixes: #12110


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/13388 **Author:** [@abhi1693](https://github.com/abhi1693) **Created:** 8/4/2023 **Status:** ✅ Merged **Merged:** 8/9/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `feat/12110-generic-tab-view` --- ### 📝 Commits (10+) - [`ef9cafe`](https://github.com/netbox-community/netbox/commit/ef9cafe602823cd5b5e676b755db397eb7325bcb) adds generic tab view template #12110 - [`fa09a47`](https://github.com/netbox-community/netbox/commit/fa09a4770f94d8aa05bdb371d3025c9c3ce34d9c) Merge branch 'develop' into feat/12110-generic-tab-view - [`d790c79`](https://github.com/netbox-community/netbox/commit/d790c79627e9d0f5787c3c4bcaad252f8f912b9d) Rename view_tab.html and move to generic/ - [`a31ea23`](https://github.com/netbox-community/netbox/commit/a31ea23bd70a94b11ad2b435cd6eac6d42d59902) Fix console ports template - [`4c2a440`](https://github.com/netbox-community/netbox/commit/4c2a4406a2452de138ccd0e12d9a757b18301521) Move bulk operations view resolution to template - [`2af2ccc`](https://github.com/netbox-community/netbox/commit/2af2ccc6c1db437f1a5d035d510beb9804c59d73) Avoid setting default template_name on ObjectChildrenView - [`9652210`](https://github.com/netbox-community/netbox/commit/9652210d56e5216728613359ed891a20184a5214) Move base_template and table_config context vars to base context - [`4633cc5`](https://github.com/netbox-community/netbox/commit/4633cc58c57b6be16d21dcfd98665db7227200c4) Merge pull request #13402 from netbox-community/13388-optimizations - [`97ff51c`](https://github.com/netbox-community/netbox/commit/97ff51c7f0ce2e6cc1a6a6745d7d55aaa7f20630) removed bulk_delete_control from templates - [`89fe8e2`](https://github.com/netbox-community/netbox/commit/89fe8e2eb3dcef8970fd4676ed1c12875d437dd1) refactored bulk_controls view ### 📊 Changes **32 files changed** (+331 additions, -1003 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/views.py` (+13 -0) 📝 `netbox/ipam/views.py` (+4 -6) 📝 `netbox/netbox/views/generic/object_views.py` (+3 -0) ➕ `netbox/templates/dcim/device/components_base.html` (+15 -0) 📝 `netbox/templates/dcim/device/consoleports.html` (+21 -51) 📝 `netbox/templates/dcim/device/consoleserverports.html` (+21 -51) 📝 `netbox/templates/dcim/device/devicebays.html` (+10 -47) 📝 `netbox/templates/dcim/device/frontports.html` (+21 -51) 📝 `netbox/templates/dcim/device/interfaces.html` (+22 -61) 📝 `netbox/templates/dcim/device/inventory.html` (+10 -47) 📝 `netbox/templates/dcim/device/modulebays.html` (+10 -43) 📝 `netbox/templates/dcim/device/poweroutlets.html` (+21 -51) 📝 `netbox/templates/dcim/device/powerports.html` (+21 -51) 📝 `netbox/templates/dcim/device/rearports.html` (+21 -51) 📝 `netbox/templates/dcim/rack/non_racked_devices.html` (+2 -41) 📝 `netbox/templates/dcim/rack/reservations.html` (+9 -40) ➕ `netbox/templates/generic/object_children.html` (+57 -0) 📝 `netbox/templates/ipam/aggregate/prefixes.html` (+2 -37) ➖ `netbox/templates/ipam/asnrange/asns.html` (+0 -36) ➖ `netbox/templates/ipam/ipaddress/ip_addresses.html` (+0 -19) _...and 12 more files_ </details> ### 📄 Description <!-- Thank you for your interest in contributing to NetBox! Please note that our contribution policy requires that a feature request or bug report be approved and assigned prior to opening a pull request. This helps avoid waste time and effort on a proposed change that we might not be able to accept. IF YOUR PULL REQUEST DOES NOT REFERENCE AN ISSUE WHICH HAS BEEN ASSIGNED TO YOU, IT WILL BE CLOSED AUTOMATICALLY. Please specify your assigned issue number on the line below. --> ### Fixes: #12110 <!-- Please include a summary of the proposed changes below. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:23:01 +01:00
adam closed this issue 2025-12-29 23:23:02 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14178