starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #8742] [MERGED] Allow filtering on Core models for Contacts #13388

New Issue
Closed
opened 2025-12-29 22:27:07 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:27:07 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/8742
Author: @minitriga
Created: 2/24/2022
Status: ✅ Merged
Merged: 3/18/2022
Merged by: @jeremystretch

Base: develop ← Head: issue_8645

📝 Commits (10+)

📊 Changes

18 files changed (+232 additions, -133 deletions)

View changed files

📝 netbox/circuits/filtersets.py (+3 -3)
📝 netbox/circuits/forms/filtersets.py (+5 -3)
📝 netbox/circuits/tables.py (+8 -2)
📝 netbox/dcim/filtersets.py (+10 -10)
📝 netbox/dcim/forms/filtersets.py (+31 -11)
📝 netbox/dcim/tables/devices.py (+5 -2)
📝 netbox/dcim/tables/devicetypes.py (+4 -1)
📝 netbox/dcim/tables/power.py (+4 -1)
📝 netbox/dcim/tables/racks.py (+4 -1)
📝 netbox/dcim/tables/sites.py (+17 -5)
📝 netbox/tenancy/filtersets.py (+94 -80)
📝 netbox/tenancy/forms/filtersets.py (+3 -1)
📝 netbox/tenancy/forms/forms.py (+15 -1)
📝 netbox/tenancy/models/contacts.py (+3 -0)
📝 netbox/tenancy/tables.py (+4 -1)
📝 netbox/virtualization/filtersets.py (+4 -4)
📝 netbox/virtualization/forms/filtersets.py (+6 -4)
📝 netbox/virtualization/tables.py (+12 -3)

📄 Description

Fixes: #8645

Implements filtering for all core models that have contacts.

  • Filter by contacts
  • Filter by contact roles
  • Allow contacts to be shown in the table columns

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/8742 **Author:** [@minitriga](https://github.com/minitriga) **Created:** 2/24/2022 **Status:** ✅ Merged **Merged:** 3/18/2022 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `issue_8645` --- ### 📝 Commits (10+) - [`36d6dd1`](https://github.com/netbox-community/netbox/commit/36d6dd1ca93a531b29b6849c2ad8d05f29dc72f2) Fixes #8645; Allow filtering on core models in the UI and API for contact assignments - [`bf22b82`](https://github.com/netbox-community/netbox/commit/bf22b820bf9e4c70b7cb420c9ef7c1660da09c29) Fixes #8645; Allow filtering on core models in the UI - [`21b7564`](https://github.com/netbox-community/netbox/commit/21b756497647e7d05563e775a34252d133161078) Merge branch 'issue_8645' of https://github.com/minitriga/netbox into issue_8645 - [`73af3ba`](https://github.com/netbox-community/netbox/commit/73af3ba095059d0be09bf0c63449a24b85b2dba6) remove contacts from api endpoints - [`412c1df`](https://github.com/netbox-community/netbox/commit/412c1df15a7dfbf1fdf1d2ba73a2f7dc76ca6475) acidentally removed NestedContactAssignmentSerializer in previous commit - [`27dab26`](https://github.com/netbox-community/netbox/commit/27dab262defe700c6bc9c06eee72bcabe4b9cad7) add columns for each model table that has contacts - [`ef6576b`](https://github.com/netbox-community/netbox/commit/ef6576bdd6c7c40be7ab3910a3ecbc24ff641be1) merge develop into issue - [`b779bbf`](https://github.com/netbox-community/netbox/commit/b779bbfc9d26067d368d8efec3b624f09279fbf1) add contacts to site table - [`342f1d3`](https://github.com/netbox-community/netbox/commit/342f1d31be0bf06fdb037fdb1fb6557a88513c76) fix pycodestyle issues - [`da37db1`](https://github.com/netbox-community/netbox/commit/da37db1ea9411cd8dcf34767a39dcc02177b225b) Update netbox/circuits/filtersets.py ### 📊 Changes **18 files changed** (+232 additions, -133 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/filtersets.py` (+3 -3) 📝 `netbox/circuits/forms/filtersets.py` (+5 -3) 📝 `netbox/circuits/tables.py` (+8 -2) 📝 `netbox/dcim/filtersets.py` (+10 -10) 📝 `netbox/dcim/forms/filtersets.py` (+31 -11) 📝 `netbox/dcim/tables/devices.py` (+5 -2) 📝 `netbox/dcim/tables/devicetypes.py` (+4 -1) 📝 `netbox/dcim/tables/power.py` (+4 -1) 📝 `netbox/dcim/tables/racks.py` (+4 -1) 📝 `netbox/dcim/tables/sites.py` (+17 -5) 📝 `netbox/tenancy/filtersets.py` (+94 -80) 📝 `netbox/tenancy/forms/filtersets.py` (+3 -1) 📝 `netbox/tenancy/forms/forms.py` (+15 -1) 📝 `netbox/tenancy/models/contacts.py` (+3 -0) 📝 `netbox/tenancy/tables.py` (+4 -1) 📝 `netbox/virtualization/filtersets.py` (+4 -4) 📝 `netbox/virtualization/forms/filtersets.py` (+6 -4) 📝 `netbox/virtualization/tables.py` (+12 -3) </details> ### 📄 Description <!-- Thank you for your interest in contributing to NetBox! Please note that our contribution policy requires that a feature request or bug report be opened for approval prior to filing a pull request. This helps avoid wasting time and effort on something that we might not be able to accept. Please indicate the relevant feature request or bug report below. IF YOUR PULL REQUEST DOES NOT REFERENCE AN ACCEPTED BUG REPORT OR FEATURE REQUEST, IT WILL BE MARKED AS INVALID AND CLOSED. --> ### Fixes: #8645 Implements filtering for all core models that have contacts. - [x] Filter by contacts - [x] Filter by contact roles - [x] Allow contacts to be shown in the table columns --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:27:07 +01:00
adam closed this issue 2025-12-29 22:27:07 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13388
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?