starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #12523] [MERGED] 12468 disallow double underscores in custom field names #14004

New Issue
Closed
opened 2025-12-29 23:21:59 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:21:59 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/12523
Author: @arthanson
Created: 5/8/2023
Status: ✅ Merged
Merged: 5/12/2023
Merged by: @jeremystretch

Base: develop ← Head: 12468-custom-field-name

📝 Commits (8)

  • 280ee13 12468 disallow double underscores in custom field names
  • 94daf74 12468 disallow double underscores in custom field names
  • 629669e 12468 review changes
  • 8b2f0cd Merge branch 'develop' into 12468-custom-field-name
  • d55162c 12468 correct migration
  • 58c74b2 12468 use inverse match
  • 050a3b7 12468 use inverse match
  • 970241e Add test for invalid custom field names

📊 Changes

3 files changed (+34 additions, -1 deletions)

View changed files

📝 netbox/extras/migrations/0066_customfield_name_validation.py (+17 -1)
📝 netbox/extras/models/customfields.py (+6 -0)
📝 netbox/extras/tests/test_customfields.py (+11 -0)

📄 Description

Fixes: #12468

Disallow double-underscore in custom field names. Unfortunately creates a migration, Jeremy what is the official way to suppress this migration?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/12523 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 5/8/2023 **Status:** ✅ Merged **Merged:** 5/12/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `12468-custom-field-name` --- ### 📝 Commits (8) - [`280ee13`](https://github.com/netbox-community/netbox/commit/280ee13361660c7b229c4fcf2b1cb96dba3b564d) 12468 disallow double underscores in custom field names - [`94daf74`](https://github.com/netbox-community/netbox/commit/94daf74635bbe750b531dbfa3d2f752b8fa085cd) 12468 disallow double underscores in custom field names - [`629669e`](https://github.com/netbox-community/netbox/commit/629669e7862f33b9bc9cec4f9ec76bf6ba734b0f) 12468 review changes - [`8b2f0cd`](https://github.com/netbox-community/netbox/commit/8b2f0cdc1ea6476a79667c657c086c4be717ab55) Merge branch 'develop' into 12468-custom-field-name - [`d55162c`](https://github.com/netbox-community/netbox/commit/d55162ce4f3ca948d331e7242d2c33835976031c) 12468 correct migration - [`58c74b2`](https://github.com/netbox-community/netbox/commit/58c74b208c4cfe97b7c103910926ef9350449047) 12468 use inverse match - [`050a3b7`](https://github.com/netbox-community/netbox/commit/050a3b789c9e1afa3b799f139e152fbbaa1b6f91) 12468 use inverse match - [`970241e`](https://github.com/netbox-community/netbox/commit/970241e8c66fa75eb2b2f4da38a65b721f40e832) Add test for invalid custom field names ### 📊 Changes **3 files changed** (+34 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/migrations/0066_customfield_name_validation.py` (+17 -1) 📝 `netbox/extras/models/customfields.py` (+6 -0) 📝 `netbox/extras/tests/test_customfields.py` (+11 -0) </details> ### 📄 Description ### Fixes: #12468 Disallow double-underscore in custom field names. Unfortunately creates a migration, Jeremy what is the official way to suppress this migration? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:21:59 +01:00
adam closed this issue 2025-12-29 23:22:00 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14004
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?