starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #3216] [MERGED] Fix 3168: Update to new path syntax #12523

New Issue
Closed
opened 2025-12-29 22:22:04 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:22:04 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3216
Author: @hellerve
Created: 5/26/2019
Status: ✅ Merged
Merged: 5/28/2019
Merged by: @jeremystretch

Base: develop ← Head: fix-3168

📝 Commits (3)

  • f9cd89a urls: fix 3168 by changing url to path
  • b114b9d utilities: add converters module and use for json/yaml url
  • 1366730 netbox urls: move to re_path as suggested by @jeremystretch

📊 Changes

9 files changed (+447 additions, -446 deletions)

View changed files

📝 netbox/circuits/urls.py (+31 -31)
📝 netbox/dcim/urls.py (+207 -207)
📝 netbox/extras/urls.py (+20 -20)
📝 netbox/ipam/urls.py (+77 -77)
📝 netbox/netbox/urls.py (+30 -29)
📝 netbox/secrets/urls.py (+15 -15)
📝 netbox/tenancy/urls.py (+16 -16)
📝 netbox/users/urls.py (+10 -10)
📝 netbox/virtualization/urls.py (+41 -41)

📄 Description

Fixes: #3168

This PR fixes #3168 by changing the URLs to the new syntax.

There should be no formatting constraints, since it seems as if Django’s and Netbox’s notion of all types (including less standardized types such as slugs) seem to match.

It also introduces the first converter to make the Swagger API URL work (it matches either .json or .yaml and as such wasn’t possible out of the box).

Cheers

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3216 **Author:** [@hellerve](https://github.com/hellerve) **Created:** 5/26/2019 **Status:** ✅ Merged **Merged:** 5/28/2019 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `fix-3168` --- ### 📝 Commits (3) - [`f9cd89a`](https://github.com/netbox-community/netbox/commit/f9cd89a4a454e91f721e5c3f49cda29ebc41e578) urls: fix 3168 by changing url to path - [`b114b9d`](https://github.com/netbox-community/netbox/commit/b114b9d39687d143c915ee21bb5673fb7077f173) utilities: add converters module and use for json/yaml url - [`1366730`](https://github.com/netbox-community/netbox/commit/1366730a3fb43e652b894d47629fbac665db1574) netbox urls: move to re_path as suggested by @jeremystretch ### 📊 Changes **9 files changed** (+447 additions, -446 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/urls.py` (+31 -31) 📝 `netbox/dcim/urls.py` (+207 -207) 📝 `netbox/extras/urls.py` (+20 -20) 📝 `netbox/ipam/urls.py` (+77 -77) 📝 `netbox/netbox/urls.py` (+30 -29) 📝 `netbox/secrets/urls.py` (+15 -15) 📝 `netbox/tenancy/urls.py` (+16 -16) 📝 `netbox/users/urls.py` (+10 -10) 📝 `netbox/virtualization/urls.py` (+41 -41) </details> ### 📄 Description ### Fixes: #3168 This PR fixes #3168 by changing the URLs to the new syntax. There should be no formatting constraints, since it seems as if Django’s and Netbox’s notion of all types (including less standardized types such as slugs) seem to match. It also introduces the first converter to make the Swagger API URL work (it matches either `.json` or `.yaml` and as such wasn’t possible out of the box). Cheers --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:22:04 +01:00
adam closed this issue 2025-12-29 22:22:04 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12523
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?