starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #11860] [CLOSED] Fixes #11812: Use object based permissions to render the right actions on tables #13859

New Issue
Closed
opened 2025-12-29 23:21:12 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:21:12 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/11860
Author: @rmanyari
Created: 2/28/2023
Status: ❌ Closed

Base: develop ← Head: GH-11812

📝 Commits (1)

  • b195918 Fixes #11812: Leverage object based permissions to render the right action buttons on tables

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 netbox/netbox/tables/columns.py (+1 -1)

📄 Description

Fixes: #11812

  • Use object based permissions to render the right actions on table rows. In particular when a user has mixed permissions that involve object constraints.

See #11812 for more background. After the fix, we can see that the edit button no longer shows on rows the user isn't allowed to change.

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/11860 **Author:** [@rmanyari](https://github.com/rmanyari) **Created:** 2/28/2023 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `GH-11812` --- ### 📝 Commits (1) - [`b195918`](https://github.com/netbox-community/netbox/commit/b1959184aa13bfa90d486c5b19bd97750feac52c) Fixes #11812: Leverage object based permissions to render the right action buttons on tables ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/tables/columns.py` (+1 -1) </details> ### 📄 Description ### Fixes: #11812 * Use object based permissions to render the right actions on table rows. In particular when a user has mixed permissions that involve object constraints. See #11812 for more background. After the fix, we can see that the edit button no longer shows on rows the user isn't allowed to change. <img width="1174" alt="image" src="https://user-images.githubusercontent.com/1471029/221996641-e211677b-0c14-42d1-bb2f-802a9873100e.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:21:12 +01:00
adam closed this issue 2025-12-29 23:21:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13859
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?