[PR #11449] [MERGED] Fixes #11431 - Disallow changing customfield type after creation #13789

New Issue

adam · 2025-12-29T23:20:48+01:00

adam commented

2025-12-29 23:20:48 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/11449
Author: @kkthxbye-code
Created: 1/10/2023
Status: ✅ Merged
Merged: 4/10/2023
Merged by: @jeremystretch

Base: develop ← Head: 11431-disallow-cf-type-edit

📝 Commits (2)

28cad7c Disallow changing customfield type after creation
011b8cf Fix test_api.CustomFieldTest

📊 Changes

3 files changed (+18 additions, -0 deletions)

View changed files

📝 netbox/extras/api/serializers.py (+6 -0)
📝 netbox/extras/forms/model_forms.py (+7 -0)
📝 netbox/extras/tests/test_api.py (+5 -0)

📄 Description

Fixes: #11431

For the API this is the simplest fix. I played around with dynamically choosing another serializer based on the action, but I couldn't get it working properly. Not sure if there's any good solution for omitting the type field in the put/patch in the swagger definition?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/11449 **Author:** [@kkthxbye-code](https://github.com/kkthxbye-code) **Created:** 1/10/2023 **Status:** ✅ Merged **Merged:** 4/10/2023 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `11431-disallow-cf-type-edit` --- ### 📝 Commits (2) - [`28cad7c`](https://github.com/netbox-community/netbox/commit/28cad7c2f9aae6c2707aa01c67726f18dd796f1c) Disallow changing customfield type after creation - [`011b8cf`](https://github.com/netbox-community/netbox/commit/011b8cf4832a1f2146acbf6031897a5cbe4bc77c) Fix test_api.CustomFieldTest ### 📊 Changes **3 files changed** (+18 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/api/serializers.py` (+6 -0) 📝 `netbox/extras/forms/model_forms.py` (+7 -0) 📝 `netbox/extras/tests/test_api.py` (+5 -0) </details> ### 📄 Description ### Fixes: #11431 For the API this is the simplest fix. I played around with dynamically choosing another serializer based on the action, but I couldn't get it working properly. Not sure if there's any good solution for omitting the type field in the put/patch in the swagger definition? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 23:20:48 +01:00

adam closed this issue

2025-12-29 23:20:48 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#13789