starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

add return_url to Add button for missing prerequisite. #11431

New Issue
Closed
opened 2025-12-29 21:45:09 +01:00 by adam · 7 comments
adam commented 2025-12-29 21:45:09 +01:00
Owner
Copy Link

Originally created by @9er-tom on GitHub (Jul 31, 2025).

Originally assigned to: @9er-tom on GitHub.

NetBox version

v4.3.4

Feature type

New functionality

Proposed functionality

Setting a return_url to the current page when adding a new model through the Add button in the missing prerequisite dialog box would easily streamline the workflow filling an empty database, without having to navigate through the menu after adding each missing prerequisite model.

Image

Use case

Remove unnecessary menu navigation when trying to add a model with missing prerequisites. For example, adding a device on a fresh, empty database requires me to add a device role, device type and site. If I don't remember each prerequisite for the object I want to add, I have to navigate back to the Add Device page after creating each object. This is even more annoying when the prerequisites have prerequisites on their own.

Database changes

No response

External dependencies

No response

Originally created by @9er-tom on GitHub (Jul 31, 2025). Originally assigned to: @9er-tom on GitHub. ### NetBox version v4.3.4 ### Feature type New functionality ### Proposed functionality Setting a return_url to the current page when adding a new model through the Add button in the missing prerequisite dialog box would easily streamline the workflow filling an empty database, without having to navigate through the menu after adding each missing prerequisite model. <img width="606" height="220" alt="Image" src="https://github.com/user-attachments/assets/9e570986-17b3-4971-bb28-5c1f7e480a82" /> ### Use case Remove unnecessary menu navigation when trying to add a model with missing prerequisites. For example, adding a device on a fresh, empty database requires me to add a device role, device type and site. If I don't remember each prerequisite for the object I want to add, I have to navigate back to the Add Device page after creating each object. This is even more annoying when the prerequisites have prerequisites on their own. ### Database changes _No response_ ### External dependencies _No response_
adam added the status: acceptedtype: featurecomplexity: low labels 2025-12-29 21:45:09 +01:00
adam closed this issue 2025-12-29 21:45:09 +01:00
adam commented 2025-12-29 21:45:10 +01:00
Author
Owner
Copy Link

@jnovinger commented on GitHub (Aug 4, 2025):

Is this something you'd be interested in contributing, @9er-tom ?

@jnovinger commented on GitHub (Aug 4, 2025): Is this something you'd be interested in contributing, @9er-tom ?
adam commented 2025-12-29 21:45:10 +01:00
Author
Owner
Copy Link

@9er-tom commented on GitHub (Aug 4, 2025):

Is this something you'd be interested in contributing, @9er-tom ?

Yes! I'm currently on vacation and I already planned to tackle this issue myself as soon as I'm back.

@9er-tom commented on GitHub (Aug 4, 2025): > Is this something you'd be interested in contributing, @9er-tom ? Yes! I'm currently on vacation and I already planned to tackle this issue myself as soon as I'm back.
adam commented 2025-12-29 21:45:11 +01:00
Author
Owner
Copy Link

@jnovinger commented on GitHub (Aug 4, 2025):

Excellent, thanks! I'm going to leave it as "needs owner" for the time being, in case somebody wants to grab it in the meantime. But, holler when you get back and I'll be happy to assign it to you.

@jnovinger commented on GitHub (Aug 4, 2025): Excellent, thanks! I'm going to leave it as "needs owner" for the time being, in case somebody wants to grab it in the meantime. But, holler when you get back and I'll be happy to assign it to you.
adam commented 2025-12-29 21:45:11 +01:00
Author
Owner
Copy Link

@9er-tom commented on GitHub (Aug 19, 2025):

I am back and already implemented the change. You can assign the issue to me and then I will open a PR to avoid getting the PR closed automatically

@9er-tom commented on GitHub (Aug 19, 2025): I am back and already implemented the change. You can assign the issue to me and then I will open a PR to avoid getting the PR closed automatically
adam commented 2025-12-29 21:45:11 +01:00
Author
Owner
Copy Link

@jnovinger commented on GitHub (Aug 19, 2025):

@9er-tom , apologies. At the moment, we're discussing whether this ought to target main or feature (if so, then it probably needs to wait until we're ready to accept v4.5.0 work in a couple of weeks). At either rate, we do not actually use the develop branch anymore, so you can close that PR for the moment.

I'll update the thread when I have more info.

@jnovinger commented on GitHub (Aug 19, 2025): @9er-tom , apologies. At the moment, we're discussing whether this ought to target `main` or `feature` (if so, then it probably needs to wait until we're ready to accept v4.5.0 work in a couple of weeks). At either rate, we do not actually use the `develop` branch anymore, so you can close that PR for the moment. I'll update the thread when I have more info.
adam commented 2025-12-29 21:45:11 +01:00
Author
Owner
Copy Link

@9er-tom commented on GitHub (Aug 19, 2025):

Ah my bad, google lead me to the old contribution readme which states that pull requests should be based off the develop branch.
https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md#arrow_heading_up-submitting-pull-requests

Just let me know on how to proceed and I will open another PR

@9er-tom commented on GitHub (Aug 19, 2025): Ah my bad, google lead me to the old contribution readme which states that pull requests should be based off the develop branch. https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md#arrow_heading_up-submitting-pull-requests Just let me know on how to proceed and I will open another PR
adam commented 2025-12-29 21:45:11 +01:00
Author
Owner
Copy Link

@jnovinger commented on GitHub (Aug 19, 2025):

No worries. This can go ahead and target main. Thanks!

@jnovinger commented on GitHub (Aug 19, 2025): No worries. This can go ahead and target `main`. Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label complexity: low status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11431
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?