[PR #10900] [MERGED] #10694: Emit post_save signal when creating/updating device components in bulk #13711

New Issue

adam · 2025-12-29T23:20:23+01:00

adam commented

2025-12-29 23:20:23 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/10900
Author: @jeremystretch
Created: 11/11/2022
Status: ✅ Merged
Merged: 11/14/2022
Merged by: @jeremystretch

Base: feature ← Head: 10694-bulk_create-signals

📝 Commits (2)

ab8efd6 Emit post_save signal when creating/updating device components in bulk
a26dab4 Fix post_save for bulk_update()

📊 Changes

1 file changed (+64 additions, -33 deletions)

View changed files

📝 netbox/dcim/models/devices.py (+64 -33)

📄 Description

Fixes: #10694

This PR is an alternative to #10780. Rather than removing the calls to bulk_create() and bulk_update(), it leaves them in place and manually emits the post_save signal for each object.

I've restricted the scope of this PR to the bulk creation and modification of device components, as I don't believe the few other instances of bulk operation usage called out in #10694 are harmful (though it's entirely possible I'm wrong).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/10900 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 11/11/2022 **Status:** ✅ Merged **Merged:** 11/14/2022 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `10694-bulk_create-signals` --- ### 📝 Commits (2) - [`ab8efd6`](https://github.com/netbox-community/netbox/commit/ab8efd6e5f89191e75de69d89cb0e5c331850f90) Emit post_save signal when creating/updating device components in bulk - [`a26dab4`](https://github.com/netbox-community/netbox/commit/a26dab4fb17f27925576310623b77afca2bde699) Fix post_save for bulk_update() ### 📊 Changes **1 file changed** (+64 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/models/devices.py` (+64 -33) </details> ### 📄 Description ### Fixes: #10694 This PR is an alternative to #10780. Rather than removing the calls to `bulk_create()` and `bulk_update()`, it leaves them in place and manually emits the `post_save` signal for each object. I've restricted the scope of this PR to the bulk creation and modification of device components, as I don't believe the few other instances of bulk operation usage called out in #10694 are harmful (though it's entirely possible I'm wrong). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 23:20:23 +01:00

adam closed this issue

2025-12-29 23:20:23 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#13711