starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #6334] [MERGED] Closes #6320: Add tests for created & last_updated fields #13119

New Issue
Closed
opened 2025-12-29 22:25:30 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:25:30 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/6334
Author: @jeremystretch
Created: 5/3/2021
Status: ✅ Merged
Merged: 5/3/2021
Merged by: @jeremystretch

Base: develop ← Head: 6320-filterset-testing

📝 Commits (4)

  • fbffef1 Rename FilterSet test modules
  • ffa4cd1 Introduce BaseFilterSetTests to standardize testing of PK filters
  • ad19b09 Fixes #6333: Fix filtering of circuit terminations by primary key
  • 3bd99e1 Closes #6320: Introduce ChangeLoggedFilterSetTests

📊 Changes

13 files changed (+131 additions, -338 deletions)

View changed files

📝 docs/release-notes/version-2.11.md (+1 -0)
📝 netbox/circuits/filtersets.py (+1 -1)
📝 netbox/circuits/tests/test_filtersets.py (+6 -21)
📝 netbox/dcim/tests/test_filtersets.py (+34 -165)
📝 netbox/extras/filtersets.py (+1 -0)
📝 netbox/extras/tests/test_filtersets.py (+25 -40)
📝 netbox/ipam/tests/test_filtersets.py (+11 -50)
📝 netbox/secrets/tests/test_filtersets.py (+3 -10)
📝 netbox/tenancy/tests/test_filtersets.py (+3 -10)
📝 netbox/users/tests/test_filtersets.py (+4 -15)
📝 netbox/utilities/testing/__init__.py (+1 -0)
➕ netbox/utilities/testing/filtersets.py (+35 -0)
📝 netbox/virtualization/tests/test_filtersets.py (+6 -26)

📄 Description

Closes: #6320

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/6334 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 5/3/2021 **Status:** ✅ Merged **Merged:** 5/3/2021 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `6320-filterset-testing` --- ### 📝 Commits (4) - [`fbffef1`](https://github.com/netbox-community/netbox/commit/fbffef1cc443ef55d8a5f2327798f05b3e7068e0) Rename FilterSet test modules - [`ffa4cd1`](https://github.com/netbox-community/netbox/commit/ffa4cd134b6e5c00552761618ef0d7d4134d6edc) Introduce BaseFilterSetTests to standardize testing of PK filters - [`ad19b09`](https://github.com/netbox-community/netbox/commit/ad19b09ae31c698e9f77045159220233e1a4c668) Fixes #6333: Fix filtering of circuit terminations by primary key - [`3bd99e1`](https://github.com/netbox-community/netbox/commit/3bd99e1910b1343a649a9643e92cd644d9a1c44c) Closes #6320: Introduce ChangeLoggedFilterSetTests ### 📊 Changes **13 files changed** (+131 additions, -338 deletions) <details> <summary>View changed files</summary> 📝 `docs/release-notes/version-2.11.md` (+1 -0) 📝 `netbox/circuits/filtersets.py` (+1 -1) 📝 `netbox/circuits/tests/test_filtersets.py` (+6 -21) 📝 `netbox/dcim/tests/test_filtersets.py` (+34 -165) 📝 `netbox/extras/filtersets.py` (+1 -0) 📝 `netbox/extras/tests/test_filtersets.py` (+25 -40) 📝 `netbox/ipam/tests/test_filtersets.py` (+11 -50) 📝 `netbox/secrets/tests/test_filtersets.py` (+3 -10) 📝 `netbox/tenancy/tests/test_filtersets.py` (+3 -10) 📝 `netbox/users/tests/test_filtersets.py` (+4 -15) 📝 `netbox/utilities/testing/__init__.py` (+1 -0) ➕ `netbox/utilities/testing/filtersets.py` (+35 -0) 📝 `netbox/virtualization/tests/test_filtersets.py` (+6 -26) </details> ### 📄 Description ### Closes: #6320 - Adds BaseFilterSetTests to standardize `test_id()` - Adds ChangeLoggedFilterSetTests to introduce `test_created()` and `test_last_updated()` - Also fixes #6333 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:25:30 +01:00
adam closed this issue 2025-12-29 22:25:31 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13119
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?