[PR #4433] [MERGED] Change PLUGINS_ENABLED to a list of specific plugins (PLUGINS) #12845

Closed
opened 2025-12-29 22:23:56 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/4433
Author: @jeremystretch
Created: 4/1/2020
Status: Merged
Merged: 4/1/2020
Merged by: @jeremystretch

Base: develop-2.8Head: plugins-list


📝 Commits (1)

  • f469c79 Change PLUGINS_ENABLED to a list of specific plugins (PLUGINS)

📊 Changes

4 files changed (+89 additions, -77 deletions)

View changed files

📝 docs/configuration/optional-settings.md (+12 -12)
📝 docs/plugins/development.md (+5 -4)
📝 docs/plugins/index.md (+5 -3)
📝 netbox/netbox/settings.py (+67 -58)

📄 Description

  • Changes PLUGINS_ENABLED from a boolean to a list of plugin names; renamed to PLUGINS.
  • Requires a plugin to declare a config pointing to a specific PluginConfig (similar to Django's default_app_config). We could find PluginConfig subclasses automatically, but this is a) more explicit, and b) allows a plugin author to change out configs dynamically in response to environment variables or other factors.
  • Removes the need for declaring entry points in setup.py.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/4433 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 4/1/2020 **Status:** ✅ Merged **Merged:** 4/1/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop-2.8` ← **Head:** `plugins-list` --- ### 📝 Commits (1) - [`f469c79`](https://github.com/netbox-community/netbox/commit/f469c794cea0401952944021b6b80cec63e6e560) Change PLUGINS_ENABLED to a list of specific plugins (PLUGINS) ### 📊 Changes **4 files changed** (+89 additions, -77 deletions) <details> <summary>View changed files</summary> 📝 `docs/configuration/optional-settings.md` (+12 -12) 📝 `docs/plugins/development.md` (+5 -4) 📝 `docs/plugins/index.md` (+5 -3) 📝 `netbox/netbox/settings.py` (+67 -58) </details> ### 📄 Description - Changes `PLUGINS_ENABLED` from a boolean to a list of plugin names; renamed to `PLUGINS`. - Requires a plugin to declare a `config` pointing to a specific PluginConfig (similar to Django's `default_app_config`). We _could_ find PluginConfig subclasses automatically, but this is a) more explicit, and b) allows a plugin author to change out configs dynamically in response to environment variables or other factors. - Removes the need for declaring entry points in `setup.py`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:23:56 +01:00
adam closed this issue 2025-12-29 22:23:56 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12845